third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp - Issue 1819603003: Shift flowthread-to-visual coordinate space conversion one level up in the tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 1819603003: Shift flowthread-to-visual coordinate space conversion one level up in the tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update unit tests. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/CaretBase.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

index 0042a5e907dd18211b4ab73675f1f20f5592ef31..af2bed6fa3b128e709ace02be291992f5c2867c9 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

@@ -866,8 +866,8 @@ const LayoutObject* LayoutBoxModelObject::pushMappingToContainer(const LayoutBox

LayoutSize containerOffset = offsetFromContainer(container);

bool offsetDependsOnPoint;

- if (container->isLayoutFlowThread()) {

- containerOffset += container->columnOffset(toLayoutPoint(containerOffset));

+ if (isLayoutFlowThread()) {

+ containerOffset += columnOffset(LayoutPoint());

offsetDependsOnPoint = true;

} else {

offsetDependsOnPoint = container->style()->isFlippedBlocksWritingMode() && container->isBox();

« no previous file with comments | « third_party/WebKit/Source/core/editing/CaretBase.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »