third_party/WebKit/Source/core/editing/CaretBase.cpp - Issue 1819603003: Shift flowthread-to-visual coordinate space conversion one level up in the tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/CaretBase.cpp

Issue 1819603003: Shift flowthread-to-visual coordinate space conversion one level up in the tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update unit tests. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/abspos-in-overflow-hidden-in-2nd-column-expected.html ('k') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/CaretBase.cpp

diff --git a/third_party/WebKit/Source/core/editing/CaretBase.cpp b/third_party/WebKit/Source/core/editing/CaretBase.cpp

index cbf557976a0b009a6a7928e2eed1d1cbead4d09a..7c8ecbb0c4ad827c20cc48e960c36a223acb4fee 100644

--- a/third_party/WebKit/Source/core/editing/CaretBase.cpp

+++ b/third_party/WebKit/Source/core/editing/CaretBase.cpp

@@ -83,12 +83,6 @@ static void mapCaretRectToCaretPainter(LayoutItem caretLayoutItem, LayoutBlockIt

break;

}

caretRect.move(caretLayoutItem.offsetFromContainer(containerItem));

- // TODO(mstensho): Fix crbug.com/596070 and get rid of this flowthread/multicol thing

- // here. It was added to keep the same behavior as before flowthread-to-visual coordinate

- // space conversion was moved out from offsetFromContainer() to mapLocalToAncestor().

- caretRect.move(containerItem.columnOffset(caretRect.location()));

caretLayoutItem = containerItem;

}