Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 1819603003: Shift flowthread-to-visual coordinate space conversion one level up in the tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update unit tests. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 848 matching lines...) Expand 10 before | Expand all | Expand 10 after
859 859
860 LayoutSize adjustmentForSkippedAncestor; 860 LayoutSize adjustmentForSkippedAncestor;
861 if (ancestorSkipped) { 861 if (ancestorSkipped) {
862 // There can't be a transform between paintInvalidationContainer and anc estorToStopAt, because transforms create containers, so it should be safe 862 // There can't be a transform between paintInvalidationContainer and anc estorToStopAt, because transforms create containers, so it should be safe
863 // to just subtract the delta between the ancestor and ancestorToStopAt. 863 // to just subtract the delta between the ancestor and ancestorToStopAt.
864 adjustmentForSkippedAncestor = -ancestorToStopAt->offsetFromAncestorCont ainer(container); 864 adjustmentForSkippedAncestor = -ancestorToStopAt->offsetFromAncestorCont ainer(container);
865 } 865 }
866 866
867 LayoutSize containerOffset = offsetFromContainer(container); 867 LayoutSize containerOffset = offsetFromContainer(container);
868 bool offsetDependsOnPoint; 868 bool offsetDependsOnPoint;
869 if (container->isLayoutFlowThread()) { 869 if (isLayoutFlowThread()) {
870 containerOffset += container->columnOffset(toLayoutPoint(containerOffset )); 870 containerOffset += columnOffset(LayoutPoint());
871 offsetDependsOnPoint = true; 871 offsetDependsOnPoint = true;
872 } else { 872 } else {
873 offsetDependsOnPoint = container->style()->isFlippedBlocksWritingMode() && container->isBox(); 873 offsetDependsOnPoint = container->style()->isFlippedBlocksWritingMode() && container->isBox();
874 } 874 }
875 875
876 bool preserve3D = container->style()->preserves3D() || style()->preserves3D( ); 876 bool preserve3D = container->style()->preserves3D() || style()->preserves3D( );
877 GeometryInfoFlags flags = 0; 877 GeometryInfoFlags flags = 0;
878 if (preserve3D) 878 if (preserve3D)
879 flags |= AccumulatingTransform; 879 flags |= AccumulatingTransform;
880 if (offsetDependsOnPoint) 880 if (offsetDependsOnPoint)
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
965 if (rootElementStyle->hasBackground()) 965 if (rootElementStyle->hasBackground())
966 return false; 966 return false;
967 967
968 if (node() != document().firstBodyElement()) 968 if (node() != document().firstBodyElement())
969 return false; 969 return false;
970 970
971 return true; 971 return true;
972 } 972 }
973 973
974 } // namespace blink 974 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/CaretBase.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698