Source/platform/graphics/filters/FELighting.h - Issue 181943003: Scaling and offset fix for FELighting (software and skia paths)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/filters/FELighting.h

Issue 181943003: Scaling and offset fix for FELighting (software and skia paths) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/graphics/filters/DistantLightSource.h ('K') | « Source/platform/graphics/filters/DistantLightSource.cpp ('k') | Source/platform/graphics/filters/FELighting.cpp » ('j') | Source/platform/graphics/filters/FELighting.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/filters/FELighting.h

diff --git a/Source/platform/graphics/filters/FELighting.h b/Source/platform/graphics/filters/FELighting.h

index a50f5a77b40d2d1ea8a73bf6cabbbfe35b472fb8..dbe81e9aab255b44e3e6855bbd58d15b3df18010 100644

--- a/Source/platform/graphics/filters/FELighting.h

+++ b/Source/platform/graphics/filters/FELighting.h

@@ -61,6 +61,8 @@ protected:

int widthMultipliedByPixelSize;

int widthDecreasedByOne;

int heightDecreasedByOne;

+ FloatSize originOffset;

+ FloatPoint3D worldScale;

inline void topLeft(int offset, IntPoint& normalVector);

inline void topRow(int offset, IntPoint& normalVector);

@@ -122,6 +124,8 @@ protected:

private:

virtual void applySoftware() OVERRIDE;

virtual bool applySkia() OVERRIDE;

+ void getTransform(FloatSize* offset, FloatPoint3D* scale) const;

};

} // namespace WebCore