Source/platform/graphics/filters/DistantLightSource.cpp - Issue 181943003: Scaling and offset fix for FELighting (software and skia paths)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/filters/DistantLightSource.cpp

Issue 181943003: Scaling and offset fix for FELighting (software and skia paths) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/graphics/filters/DistantLightSource.h ('K') | « Source/platform/graphics/filters/DistantLightSource.h ('k') | Source/platform/graphics/filters/FELighting.h » ('j') | Source/platform/graphics/filters/FELighting.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/filters/DistantLightSource.cpp

diff --git a/Source/platform/graphics/filters/DistantLightSource.cpp b/Source/platform/graphics/filters/DistantLightSource.cpp

index 6da197cbb895d59722e6e7f046d93579b9006855..b7280079cce388a47e6c33829819bfedf4e7febb 100644

--- a/Source/platform/graphics/filters/DistantLightSource.cpp

+++ b/Source/platform/graphics/filters/DistantLightSource.cpp

@@ -35,7 +35,7 @@

namespace WebCore {

-void DistantLightSource::initPaintingData(PaintingData& paintingData)

+void DistantLightSource::initPaintingData(PaintingData& paintingData) const

{

float azimuth = deg2rad(m_azimuth);

float elevation = deg2rad(m_elevation);

@@ -45,7 +45,7 @@ void DistantLightSource::initPaintingData(PaintingData& paintingData)

paintingData.lightVectorLength = 1;

}

-void DistantLightSource::updatePaintingData(PaintingData&, int, int, float)

+void DistantLightSource::updatePaintingData(PaintingData&, float, float, float) const

{

}