Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1819223003: Revert of Clean up SSSE3 and SSE4 stubs. (Closed)

Created:
4 years, 9 months ago by mtklein
Modified:
4 years, 9 months ago
Reviewers:
djsollen, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Clean up SSSE3 and SSE4 stubs. (patchset #1 id:1 of https://codereview.chromium.org/1810183003/ ) Reason for revert: I've just had a better idea about how to fix this. Let's revert while I work on it. Original issue's description: > Clean up SSSE3 and SSE4 stubs. > > We added these stubs to work around OpenBSD's old compiler, which had > support for SSE2 but not SSSE3 or SSE4. > > We now already have other unstubbed files that require SSSE3 and SSE4 compiler > support. All the compilers we support have SSSE3 and SSE4 support, and all the > way up to at least AVX2. > > (Requiring C++11 has had some nice ripple effects...) > > > And, <immintrin.h> is already auto-included for these files, so no need for smmintrin or tmmintrin. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1810183003 > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/2b1b40e11afc41452b4d2f74cdebb1b6e6f7cc96 TBR=djsollen@google.com,mtklein@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ee451cf09de31267c93b64e1fdac7c823cee7e85

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M src/opts/SkBitmapProcState_opts_SSSE3.cpp View 2 chunks +36 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_SSE4.cpp View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of Clean up SSSE3 and SSE4 stubs.
4 years, 9 months ago (2016-03-22 14:17:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819223003/1
4 years, 9 months ago (2016-03-22 14:17:35 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 14:28:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ee451cf09de31267c93b64e1fdac7c823cee7e85

Powered by Google App Engine
This is Rietveld 408576698