Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 18190006: If a user requests a try on "all" builders, ask for confirmation (Closed)

Created:
7 years, 5 months ago by borenet
Modified:
7 years, 5 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

If a user requests a try on "all" builders, ask for confirmation Addresses https://code.google.com/p/skia/issues/detail?id=1208 (SkipBuildbotRuns) R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=10049

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M tools/submit_try View 1 chunk +9 lines, -2 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
borenet
Is this sufficient to cover https://code.google.com/p/skia/issues/detail?id=1208 ? I think that if a user takes the ...
7 years, 5 months ago (2013-07-09 20:36:11 UTC) #1
epoger
lgtm
7 years, 5 months ago (2013-07-12 15:13:30 UTC) #2
borenet
7 years, 5 months ago (2013-07-12 18:11:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r10049 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698