Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: tools/submit_try

Issue 18190006: If a user requests a try on "all" builders, ask for confirmation (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/submit_try
===================================================================
--- tools/submit_try (revision 9919)
+++ tools/submit_try (working copy)
@@ -205,9 +205,16 @@
Error('Cannot specify "%s" with additional builder names or '
'aliases.' % bot)
if bot == ALL_BUILDERS:
- using_bots = trybots
+ are_you_sure = raw_input('Running a try on every bot is very '
+ 'expensive. You may be able to get '
+ 'enough information by running on a '
+ 'smaller set of bots. Are you sure you '
+ 'want to run your try job on all of the '
+ 'trybots? [y,n]: ')
+ if are_you_sure == 'y':
+ using_bots = trybots
elif bot == COMPILE_BUILDERS:
- using_bots = [t for t in trybots if '_Compile_' in t]
+ using_bots = [t for t in trybots if t.startswith('Build')]
borenet 2013/07/09 20:36:11 Unfortunately, this didn't get changed after the b
elif bot == CQ_BUILDERS:
using_bots = RetrieveTrybotList(json_filename='cqtrybots')
elif bot == REGEX:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698