If a user requests a try on "all" builders, ask for confirmation

tools/submit_try

 #!/usr/bin/python
 
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 """
 submit_try: Submit a try request.
 
@@ skipping 187 matching lines @@
       if len(argv) < 1:
         Error('You must specify a builder with "--bot".')
       using_bots = []
       while argv and not argv[0].startswith('-'):
         for bot in argv.pop(0).split(','):
           if bot in ALL_ALIASES:
             if using_bots:
               Error('Cannot specify "%s" with additional builder names or '
                     'aliases.' % bot)
             if bot == ALL_BUILDERS:
-              using_bots = trybots
+              are_you_sure = raw_input('Running a try on every bot is very '
+                                       'expensive. You may be able to get '
+                                       'enough information by running on a '
+                                       'smaller set of bots. Are you sure you '
+                                       'want to run your try job on all of the '
+                                       'trybots? [y,n]: ')
+              if are_you_sure == 'y':
+                using_bots = trybots
             elif bot == COMPILE_BUILDERS:
-              using_bots = [t for t in trybots if '_Compile_' in t]
+              using_bots = [t for t in trybots if t.startswith('Build')]

[borenet, 2013/07/09 20:36:11]

Unfortunately, this didn't get changed after the builder name change.

             elif bot == CQ_BUILDERS:
               using_bots = RetrieveTrybotList(json_filename='cqtrybots')
             elif bot == REGEX:
               while True:
                 regex = raw_input("Enter your trybot regex: ")
                 p = re.compile(regex)
                 using_bots = [t for t in trybots if p.match(t)]
                 print '\n\nTrybots that match your regex:\n%s\n\n' % '\n'.join(
                     using_bots)
                 if raw_input('Re-enter regex? [y,n]: ') == 'n':
@@ skipping 70 matching lines @@
 
   # Parse and validate the command-line arguments.
   args = ValidateArgs(sys.argv[1:], trybots=trybots, is_svn=is_svn)
 
   # Submit the try request.
   SubmitTryRequest(args, is_svn=is_svn)
 
 
 if __name__ == '__main__':
   sys.exit(main())