Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1818923003: [Tracing benchmark] Put maxEventBytesPerCategory into diagnostics (Closed)

Created:
4 years, 9 months ago by Zhen Wang
Modified:
4 years, 9 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, nednguyen, tracing-review_chromium.org
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Tracing benchmark] Put maxEventBytesPerCategory into diagnostics maxEventBytesPerCategory could change from one category to another category in different runs. It is not suitable to be shown on the dashboard. This CL puts such information into the diagnostics, so when regression happens, people may still benefit from it. BUG=catapult:#2078 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8d9e4952d037919b3e4c5167026c5a95baef93f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -15 lines) Patch
M tracing/tracing/metrics/tracing_metric.html View 1 chunk +13 lines, -9 lines 0 comments Download
M tracing/tracing/metrics/tracing_metric_test.html View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Zhen Wang
ptal
4 years, 9 months ago (2016-03-21 21:19:02 UTC) #4
eakuefner
lgtm
4 years, 9 months ago (2016-03-21 22:41:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818923003/1
4 years, 9 months ago (2016-03-21 22:41:40 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 23:13:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698