Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: tracing/tracing/metrics/tracing_metric_test.html

Issue 1818923003: [Tracing benchmark] Put maxEventBytesPerCategory into diagnostics (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/metrics/tracing_metric.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/tracing_metric_test.html
diff --git a/tracing/tracing/metrics/tracing_metric_test.html b/tracing/tracing/metrics/tracing_metric_test.html
index 804e91775d5a813494dda1e944eabc6d80715122..aca6c3fdb416a59a9bad2cc590fefa26517760c7 100644
--- a/tracing/tracing/metrics/tracing_metric_test.html
+++ b/tracing/tracing/metrics/tracing_metric_test.html
@@ -89,7 +89,7 @@ tr.b.unittest.testSuite(function() {
assert.strictEqual(values[0].numeric.value, maxEventBytesPerSec);
});
- test('maxEventBytesPerCategory', function() {
+ test('diagnostics', function() {
var valueList = new tr.metrics.ValueList();
var events = [
{name: 'a', args: {}, pid: 52, ts: 524, cat: 'foo', tid: 53, ph: 'B'},
@@ -102,11 +102,14 @@ tr.b.unittest.testSuite(function() {
model.canonicalUrlThatCreatedThisTrace = '';
tr.metrics.tracingMetric(valueList, model);
- var fooCategoryEventSize = getEventStringSize(events, [0, 1, 3]);
- var values = valueList.getValuesWithName(
- 'Max event size in bytes per category');
- assert.strictEqual(values.length, 1);
- assert.strictEqual(values[0].numeric.value, fooCategoryEventSize);
+ for (var i = 0; i < valueList.length; i++) {
+ assert.strictEqual(
+ values[i].diagnostics.category_with_max_event_size.name,
+ 'foo');
+ assert.strictEqual(
+ values[i].diagnostics.category_with_max_event_size.size_in_bytes,
+ getEventStringSize(events, [0, 1, 3]));
+ }
});
});
« no previous file with comments | « tracing/tracing/metrics/tracing_metric.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698