Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: tracing/tracing/metrics/tracing_metric.html

Issue 1818923003: [Tracing benchmark] Put maxEventBytesPerCategory into diagnostics (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tracing/tracing/metrics/tracing_metric_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/tracing_metric.html
diff --git a/tracing/tracing/metrics/tracing_metric.html b/tracing/tracing/metrics/tracing_metric.html
index f270b4184fd24e68412a00674fecd6b19b9368d9..c8d8785b651c6f9e6e1ccc8639b3d9747a4bcb1a 100644
--- a/tracing/tracing/metrics/tracing_metric.html
+++ b/tracing/tracing/metrics/tracing_metric.html
@@ -86,25 +86,29 @@ tr.exportTo('tr.metrics', function() {
tr.v.Unit.byName.sizeInBytes_smallerIsBetter, maxEventBytesPerSec);
var totalTraceBytesValue = new tr.v.ScalarNumeric(
tr.v.Unit.byName.sizeInBytes_smallerIsBetter, totalTraceBytes);
- var maxEventBytesPerCategoryValue = new tr.v.ScalarNumeric(
- tr.v.Unit.byName.sizeInBytes_smallerIsBetter, maxEventBytesPerCategory);
+
+ var diagnostics = {
+ category_with_max_event_size: {
+ name: maxCategoryName,
+ size_in_bytes: maxEventBytesPerCategory
+ }
+ };
valueList.addValue(new tr.v.NumericValue(
model.canonicalUrlThatCreatedThisTrace,
'Total trace size in bytes',
- totalTraceBytesValue));
+ totalTraceBytesValue,
+ undefined, undefined, diagnostics));
valueList.addValue(new tr.v.NumericValue(
model.canonicalUrlThatCreatedThisTrace,
'Max number of events per second',
- maxEventCountPerSecValue));
+ maxEventCountPerSecValue,
+ undefined, undefined, diagnostics));
valueList.addValue(new tr.v.NumericValue(
model.canonicalUrlThatCreatedThisTrace,
'Max event size in bytes per second',
- maxEventBytesPerSecValue));
- valueList.addValue(new tr.v.NumericValue(
- model.canonicalUrlThatCreatedThisTrace,
- 'Max event size in bytes per category (' + maxCategoryName + ')',
- maxEventBytesPerCategoryValue));
+ maxEventBytesPerSecValue,
+ undefined, undefined, diagnostics));
}
tracingMetric.prototype = {
« no previous file with comments | « no previous file | tracing/tracing/metrics/tracing_metric_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698