Add deprecation warning banner to App Launcher on Windows and Linux.

Add deprecation warning banner to App Launcher on Windows and Linux.

Given limited usage of the Chrome App Launcher on Windows, Mac and
Linux, we're planning to remove the Launcher on these platforms later
this year to remove unnecessary complexity in the browser. This does not
affect Chrome OS.

After the removal, users will still be able to access their Chrome Apps
through the Apps bookmark, or system shortcuts.

BUG=576531
Committed: https://crrev.com/c00f1d07c1aca9fcfddbc40ed1057425cac020fc
Cr-Commit-Position: refs/heads/master@{#384501}

[Matt Giuca, 2016-03-22 08:00:11]

mgiuca@chromium.org changed reviewers:
+ tapted@chromium.org

[Matt Giuca, 2016-03-22 08:05:50]

Description was changed from

==========
Add deprecation warning banner to App Launcher on Windows and Linux.

Given limited usage of the Chrome App Launcher on Windows, Mac and
Linux, we're planning to remove the Launcher on these platforms later
this year to remove unnecessary complexity in the browser. This does not
affect Chrome OS.

After the removal, users will still be able to access their Chrome Apps
through the Apps bookmark, or system shortcuts.

BUG=576531
==========

to

==========
Add deprecation warning banner to App Launcher on Windows and Linux.

Given limited usage of the Chrome App Launcher on Windows, Mac and
Linux, we're planning to remove the Launcher on these platforms later
this year to remove unnecessary complexity in the browser. This does not
affect Chrome OS.

After the removal, users will still be able to access their Chrome Apps
through the Apps bookmark, or system shortcuts.

BUG=576531
==========

[tapted, 2016-03-24 02:56:34]

lgtm+CQ - I just have a rambling comment

https://codereview.chromium.org/1818913004/diff/1/ui/app_list/views/apps_cont...
File ui/app_list/views/apps_container_view.cc (right):

https://codereview.chromium.org/1818913004/diff/1/ui/app_list/views/apps_cont...
ui/app_list/views/apps_container_view.cc:82:
text_label->SetDisplayedOnBackgroundColor(kDeprecationBannerBackgroundColor);
I don't think this is enough to trigger subpixel AA (it would be nice if it
was..) -- it just affects "AutoColorReadability" (but maybe not having subpixel
AA isn't as jarring as it is on Mac and.. actually it looks like subpixel AA has
died from a lot of places that used to have it on the App Launcher [Mac
included..]). So. This probably doesn't matter.

I think some parent View's layer() needs to be marked properly opaque

[tapted, 2016-03-24 02:57:40]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-03-24 02:57:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818913004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818913004/1

[commit-bot: I haz the power, 2016-03-24 03:32:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 03:32:07]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[tapted, 2016-03-24 03:43:21]

On 2016/03/24 03:32:07, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

Doh test failures - a bunch. it looks like there are a few classes of problems:
 - ash_unittests still run on win8 (:o)
 - app_list_unittests doesn't have a proper delegate with strings, so
views::StyledLabel is being passed empty ranges to configure styles for
 - window size expectations on ChromeOS are changing [probably *only* the
`experimental app list` tests should be getting run there]

[tapted, 2016-03-24 04:46:12]

https://codereview.chromium.org/1818913004/diff/1/ui/app_list/views/apps_cont...
File ui/app_list/views/apps_container_view.cc (right):

https://codereview.chromium.org/1818913004/diff/1/ui/app_list/views/apps_cont...
ui/app_list/views/apps_container_view.cc:95: 1, 2,
kDeprecationBannerBorderColor));
Ah, also there's a tiny glitch here. This will paint rounded corners inside the
background, which is solid/rectangular. So there's one yellow pixel in each
corner that's outside the border. Might be more noticable on hidpi screens, but
there's not many of those.

[Matt Giuca, 2016-03-30 07:08:24]

Thanks for helping with the tests. I'll have to try to fix those tomorrow.

https://codereview.chromium.org/1818913004/diff/1/ui/app_list/views/apps_cont...
File ui/app_list/views/apps_container_view.cc (right):

https://codereview.chromium.org/1818913004/diff/1/ui/app_list/views/apps_cont...
ui/app_list/views/apps_container_view.cc:82:
text_label->SetDisplayedOnBackgroundColor(kDeprecationBannerBackgroundColor);
On 2016/03/24 02:56:34, tapted (travelling to Apr 5th) wrote:
> I don't think this is enough to trigger subpixel AA (it would be nice if it
> was..) -- it just affects "AutoColorReadability" (but maybe not having
subpixel
> AA isn't as jarring as it is on Mac and.. actually it looks like subpixel AA
has
> died from a lot of places that used to have it on the App Launcher [Mac
> included..]). So. This probably doesn't matter.
> 
> I think some parent View's layer() needs to be marked properly opaque

Graa... OK I tried the magic incantation:

deprecation_banner_box->SetPaintToLayer(true);
deprecation_banner_box->layer()->SetMasksToBounds(true);
deprecation_banner_box->layer()->SetFillsBoundsOpaquely(false);

no subpixel AA. No idea why but I have spent too long trying to debug this and I
don't think it's important, as you say.

https://codereview.chromium.org/1818913004/diff/1/ui/app_list/views/apps_cont...
ui/app_list/views/apps_container_view.cc:95: 1, 2,
kDeprecationBannerBorderColor));
On 2016/03/24 04:46:12, tapted (travelling to Apr 5th) wrote:
> Ah, also there's a tiny glitch here. This will paint rounded corners inside
the
> background, which is solid/rectangular. So there's one yellow pixel in each
> corner that's outside the border. Might be more noticable on hidpi screens,
but
> there's not many of those.

Done (now based on CL 1836353005 which adds the RoundedRectBackground class).

[Matt Giuca, 2016-03-31 02:23:23]

mgiuca@chromium.org changed reviewers:
+ calamity@chromium.org

[Matt Giuca, 2016-03-31 02:23:23]

+calamity to look at PS4

[calamity, 2016-03-31 03:16:09]

lgtm, I just didn't think it was worth refactoring out a reusable class into the
app_list folder and then delete half of its usages in a month.

[Matt Giuca, 2016-03-31 03:20:40]

On 2016/03/24 03:43:21, tapted (travelling to Apr 5th) wrote:
> On 2016/03/24 03:32:07, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> >   win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
> 
> Doh test failures - a bunch. it looks like there are a few classes of
problems:
>  - ash_unittests still run on win8 (:o)

What, that's weird. Well, I can't get into the bot failure page now so I'll just
run it again to see what the failures are. Maybe my other fixes will have fixed
this too.

>  - app_list_unittests doesn't have a proper delegate with strings, so
> views::StyledLabel is being passed empty ranges to configure styles for

Fixed.

>  - window size expectations on ChromeOS are changing [probably *only* the
> `experimental app list` tests should be getting run there]

Fixed. (Actually, changed it so the size tests only run in Chrome OS which is
the only place where the size is a) fixed, and b) we care about it.) (Still
running the non-experimental tests on Chrome OS because why not; that will get
removed when we remove the non-experimental app list.)

[Matt Giuca, 2016-03-31 06:47:20]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-03-31 06:47:20]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org,
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/1818913004/#ps80001
(title: "Fix some tests.")

[commit-bot: I haz the power, 2016-03-31 06:47:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818913004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818913004/80001

[commit-bot: I haz the power, 2016-03-31 07:36:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 07:36:44]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Matt Giuca, 2016-04-01 05:05:27]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-04-01 05:05:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org,
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/1818913004/#ps120001
(title: "Rebase on 1842373004 (fixes app list height some more on Chrome OS).")

[commit-bot: I haz the power, 2016-04-01 05:05:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818913004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818913004/120001

[commit-bot: I haz the power, 2016-04-01 06:22:50]

Description was changed from

==========
Add deprecation warning banner to App Launcher on Windows and Linux.

Given limited usage of the Chrome App Launcher on Windows, Mac and
Linux, we're planning to remove the Launcher on these platforms later
this year to remove unnecessary complexity in the browser. This does not
affect Chrome OS.

After the removal, users will still be able to access their Chrome Apps
through the Apps bookmark, or system shortcuts.

BUG=576531
==========

to

==========
Add deprecation warning banner to App Launcher on Windows and Linux.

Given limited usage of the Chrome App Launcher on Windows, Mac and
Linux, we're planning to remove the Launcher on these platforms later
this year to remove unnecessary complexity in the browser. This does not
affect Chrome OS.

After the removal, users will still be able to access their Chrome Apps
through the Apps bookmark, or system shortcuts.

BUG=576531
==========

[commit-bot: I haz the power, 2016-04-01 06:22:51]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-04-01 06:24:31]

Description was changed from

==========
Add deprecation warning banner to App Launcher on Windows and Linux.

Given limited usage of the Chrome App Launcher on Windows, Mac and
Linux, we're planning to remove the Launcher on these platforms later
this year to remove unnecessary complexity in the browser. This does not
affect Chrome OS.

After the removal, users will still be able to access their Chrome Apps
through the Apps bookmark, or system shortcuts.

BUG=576531
==========

to

==========
Add deprecation warning banner to App Launcher on Windows and Linux.

Given limited usage of the Chrome App Launcher on Windows, Mac and
Linux, we're planning to remove the Launcher on these platforms later
this year to remove unnecessary complexity in the browser. This does not
affect Chrome OS.

After the removal, users will still be able to access their Chrome Apps
through the Apps bookmark, or system shortcuts.

BUG=576531

Committed: https://crrev.com/c00f1d07c1aca9fcfddbc40ed1057425cac020fc
Cr-Commit-Position: refs/heads/master@{#384501}
==========

[commit-bot: I haz the power, 2016-04-01 06:24:32]

Patchset 7 (id:??) landed as
https://crrev.com/c00f1d07c1aca9fcfddbc40ed1057425cac020fc
Cr-Commit-Position: refs/heads/master@{#384501}