Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: ui/app_list/views/app_list_view_unittest.cc

Issue 1818913004: Add deprecation warning banner to App Launcher on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tapted-applist-deprecation-mac
Patch Set: Rebase on 1842373004 (fixes app list height some more on Chrome OS). Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/app_list/app_list_constants.cc ('k') | ui/app_list/views/apps_container_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/views/app_list_view_unittest.cc
diff --git a/ui/app_list/views/app_list_view_unittest.cc b/ui/app_list/views/app_list_view_unittest.cc
index 477875f115825e7335cf61125217baa6a878ddd6..b2631379a7c6a4eaa47666b9ba8da8b0908901d4 100644
--- a/ui/app_list/views/app_list_view_unittest.cc
+++ b/ui/app_list/views/app_list_view_unittest.cc
@@ -298,9 +298,14 @@ void AppListViewTestContext::RunDisplayTest() {
Show();
+#if defined(OS_CHROMEOS)
// Explicitly enforce the exact dimensions of the app list. Feel free to
// change these if you need to (they are just here to prevent against
// accidental changes to the window size).
+ //
+ // Note: Only test this on Chrome OS; the deprecation banner on other
+ // platforms makes the height variable so we can't reliably test it (nor do we
+ // really need to).
switch (test_type_) {
case NORMAL:
EXPECT_EQ("400x500", view_->bounds().size().ToString());
@@ -318,6 +323,7 @@ void AppListViewTestContext::RunDisplayTest() {
NOTREACHED();
break;
}
+#endif // defined(OS_CHROMEOS)
if (is_landscape())
EXPECT_EQ(2, GetPaginationModel()->total_pages());
« no previous file with comments | « ui/app_list/app_list_constants.cc ('k') | ui/app_list/views/apps_container_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698