Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1842373004: AppListFolderView now reports the correct size. [Refactor] (Closed)

Created:
4 years, 8 months ago by Matt Giuca
Modified:
4 years, 8 months ago
Reviewers:
calamity
CC:
chromium-reviews, tfarina, Matt Giuca, tapted, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@applist-learnmore-period
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AppListFolderView now reports the correct size. [Refactor] Previously, AppListFolderView included the extra height for the folder view's page switcher (which is clipped and not actually considered part of the folder view). This in turn was reported as part of the height of AppsContainerView, which was unused. Now ContentsView uses AppsContainerView's size instead of the AppsGridView size, which means we can now add new elements to the AppsContainerView (respects the abstraction layer). Should have no visible effect. BUG=576531 Committed: https://crrev.com/81423314be415a76bf7160f8810483afece52f76 Cr-Commit-Position: refs/heads/master@{#384487}

Patch Set 1 #

Patch Set 2 : Avoid dependency patch sets. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/app_list/views/apps_grid_view.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/app_list/views/contents_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Matt Giuca
4 years, 8 months ago (2016-04-01 02:38:38 UTC) #2
calamity
lgtm
4 years, 8 months ago (2016-04-01 03:34:59 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1845853004 Patch 1). Please resolve the dependency and ...
4 years, 8 months ago (2016-04-01 03:37:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842373004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842373004/20001
4 years, 8 months ago (2016-04-01 03:45:55 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-01 04:59:59 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 05:01:08 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81423314be415a76bf7160f8810483afece52f76
Cr-Commit-Position: refs/heads/master@{#384487}

Powered by Google App Engine
This is Rietveld 408576698