Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: net/quic/crypto/quic_crypto_client_config.h

Issue 1818393003: QUIC - Persist "Hash of the CHLO message" and "Signed timestamp of the (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Default chlo_hash to empty string for old disk cache data Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/crypto/quic_crypto_client_config.h
diff --git a/net/quic/crypto/quic_crypto_client_config.h b/net/quic/crypto/quic_crypto_client_config.h
index 6ecd678502ca9f438ad43bd4d1b22a421641f3ab..a0c35360da33a7dd08dd77d07de62429b084bf18 100644
--- a/net/quic/crypto/quic_crypto_client_config.h
+++ b/net/quic/crypto/quic_crypto_client_config.h
@@ -148,10 +148,10 @@ class NET_EXPORT_PRIVATE QuicCryptoClientConfig : public QuicCryptoConfig {
// SetProofVerifyDetails takes ownership of |details|.
void SetProofVerifyDetails(ProofVerifyDetails* details);
- // Copy the |server_config_|, |source_address_token_|, |certs_| and
- // |server_config_sig_| from the |other|. The remaining fields,
- // |generation_counter_|, |proof_verify_details_|, and |scfg_| remain
- // unchanged.
+ // Copy the |server_config_|, |source_address_token_|, |certs_|,
+ // |cert_sct_|, |chlo_hash_| and |server_config_sig_| from the |other|. The
+ // remaining fields, |generation_counter_|, |proof_verify_details_|, and
+ // |scfg_| remain unchanged.
void InitializeFrom(const CachedState& other);
// Initializes this cached state based on the arguments provided.
@@ -159,7 +159,7 @@ class NET_EXPORT_PRIVATE QuicCryptoClientConfig : public QuicCryptoConfig {
bool Initialize(base::StringPiece server_config,
base::StringPiece source_address_token,
const std::vector<std::string>& certs,
- const std::string& cert_sct,
+ base::StringPiece cert_sct,
base::StringPiece chlo_hash,
base::StringPiece signature,
QuicWallTime now);
« no previous file with comments | « net/quic/crypto/properties_based_quic_server_info_test.cc ('k') | net/quic/crypto/quic_crypto_client_config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698