Make more of content pass "gn check"

content/public/common/BUILD.gn

Index: content/public/common/BUILD.gn
diff --git a/content/public/common/BUILD.gn b/content/public/common/BUILD.gn
index 9075452a68dd0ddb74335af5d5599432945769bf..a40bf8fb27ca92e8471ed517c7e6231f16af2a6d 100644
--- a/content/public/common/BUILD.gn
+++ b/content/public/common/BUILD.gn
@@ -33,6 +33,10 @@ source_set("result_codes") {
 # This target allows other targets to depend on content_descriptors.h which is
 # a header-only dependency, without bringing in all of content.
 source_set("content_descriptors") {
+  # This header includes some other headers for constants, but we explicitly
+  # don't want to link anything else into here so exempt from checking.
+  check_includes = false

[Dirk Pranke, 2016/03/21 19:08:10]

it looks like this just includes build/build_config.h and ipc/ipc_descriptors.h
.

For the latter, why not split that into a separate targets?

For the former, why don't we get complaints all over the place for files that
are including build_config.h but not declaring it?

[brettw, 2016/03/21 20:44:27]

Hm, I screwed this up. I just depended on //ipc here which should be fine. For
some reason I thought this was more complicated.

+
   sources = [
     "content_descriptors.h",
   ]
@@ -91,14 +95,26 @@ source_set("common_sources") {
     "//url/ipc:url_ipc",
   ]
   deps = [
+    "//ipc",
+    "//ipc/mojo",
+    "//media",
+    "//mojo/common",
     "//net",
+    "//ppapi/c",
     "//skia",
+    "//storage/common",
     "//third_party/WebKit/public:blink_headers",
     "//third_party/icu",
+    "//ui/accessibility",
     "//ui/base",
     "//ui/gfx",
+    "//ui/gfx/ipc",
+    "//ui/surface",
   ]
 
+  # //content/common needs to include public headers.
+  allow_circular_includes_from = [ "//content/common" ]
+
   if (!enable_plugins) {
     sources -= [
       "pepper_plugin_info.cc",
@@ -132,6 +148,7 @@ buildflag_header("features") {
 source_set("feature_h264_with_openh264_ffmpeg") {
   deps = [
     ":features",
+    "//base",
   ]
   sources = [
     "feature_h264_with_openh264_ffmpeg.cc",