Issue 1827763002: Correctly parse the directive prologue in modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1827763002: Correctly parse the directive prologue in modules (Closed)

Created:
4 years, 9 months ago by nickie

Modified:
4 years, 2 months ago

Reviewers:
adamk, rossberg

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Correctly parse the directive prologue in modules R=adamk@chromium.org,rossberg@chromium.org BUG= LOG=N

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -2 lines)			Patch
	M	src/parsing/parser.cc	View		1 chunk	+36 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nickie

This is not to be landed, at least for the time being, as discussed privately ...

4 years, 8 months ago (2016-04-18 10:32:52 UTC) #3

nickie

4 years, 2 months ago (2016-09-29 09:30:26 UTC) #4

On 2016/04/18 10:32:52, nickie wrote:
> This is not to be landed, at least for the time being, as discussed privately
> with Adam and Andreas.

I'm closing this CL.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages