components/page_load_metrics/browser/page_load_metrics_observer.cc - Issue 1817263003: Allow TimeTicks for serialized page load operations to be equal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/page_load_metrics_observer.cc

Issue 1817263003: Allow TimeTicks for serialized page load operations to be equal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add param Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/page_load_metrics/browser/page_load_metrics_observer.h ('k') | components/page_load_metrics/browser/page_load_metrics_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/page_load_metrics_observer.cc

diff --git a/components/page_load_metrics/browser/page_load_metrics_observer.cc b/components/page_load_metrics/browser/page_load_metrics_observer.cc

index 23a00fbaee3f6ce879bf04cf4539156b1f8207ab..6d1dacda492853c70855b37f0adf67e8e3abf16d 100644

--- a/components/page_load_metrics/browser/page_load_metrics_observer.cc

+++ b/components/page_load_metrics/browser/page_load_metrics_observer.cc

@@ -4,6 +4,8 @@

#include "components/page_load_metrics/browser/page_load_metrics_observer.h"

+#include "base/time/time.h"

namespace page_load_metrics {

PageLoadExtraInfo::PageLoadExtraInfo(

@@ -11,6 +13,7 @@ PageLoadExtraInfo::PageLoadExtraInfo(

base::TimeDelta first_foreground_time,

bool started_in_foreground,

const GURL& committed_url,

+ bool committed,

base::TimeDelta time_to_commit,

UserAbortType abort_type,

base::TimeDelta time_to_abort)

@@ -18,6 +21,7 @@ PageLoadExtraInfo::PageLoadExtraInfo(

first_foreground_time(first_foreground_time),

started_in_foreground(started_in_foreground),

committed_url(committed_url),

+ committed(committed),

time_to_commit(time_to_commit),

abort_type(abort_type),

time_to_abort(time_to_abort) {}