Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: components/page_load_metrics/browser/page_load_metrics_observer.h

Issue 1817263003: Allow TimeTicks for serialized page load operations to be equal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add param Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/page_load_metrics_observer.h
diff --git a/components/page_load_metrics/browser/page_load_metrics_observer.h b/components/page_load_metrics/browser/page_load_metrics_observer.h
index c42f36d93ee467eab1375a7bad8abbb8b90a4441..d6767277950648aefde5c215df622b366164531e 100644
--- a/components/page_load_metrics/browser/page_load_metrics_observer.h
+++ b/components/page_load_metrics/browser/page_load_metrics_observer.h
@@ -55,6 +55,7 @@ struct PageLoadExtraInfo {
base::TimeDelta first_foreground_time,
bool started_in_foreground,
const GURL& committed_url,
+ bool committed,
base::TimeDelta time_to_commit,
UserAbortType abort_type,
base::TimeDelta time_to_abort);
@@ -74,8 +75,11 @@ struct PageLoadExtraInfo {
// empty.
const GURL committed_url;
- // Time from navigation start until commit. If the page load did not commit,
- // |time_to_commit| will be zero.
+ // Whether the navigation was committed.
+ // TODO(csharrison): Consider replacing this with Option<time_to_commit>.
+ const bool committed;
+
+ // Time from navigation start until commit. Only valid if |committed| is true.
const base::TimeDelta time_to_commit;
// The abort time and time to abort for this page load. If the page was not

Powered by Google App Engine
This is Rietveld 408576698