components/page_load_metrics/browser/page_load_metrics_util.h - Issue 1817263003: Allow TimeTicks for serialized page load operations to be equal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/page_load_metrics_util.h

Issue 1817263003: Allow TimeTicks for serialized page load operations to be equal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add param Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/page_load_metrics/browser/page_load_metrics_observer.cc ('k') | components/page_load_metrics/browser/page_load_metrics_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/page_load_metrics_util.h

diff --git a/components/page_load_metrics/browser/page_load_metrics_util.h b/components/page_load_metrics/browser/page_load_metrics_util.h

index 380c077d26357ae6db44339bbbdacfe9b45692b6..e10636597ed6104a6f6c3bda2dd70c6e34649810 100644

--- a/components/page_load_metrics/browser/page_load_metrics_util.h

+++ b/components/page_load_metrics/browser/page_load_metrics_util.h

@@ -25,7 +25,11 @@ struct PageLoadTiming;

// When a page is backgrounded, some events (e.g. paint) are delayed. Since

// these data points can skew the mean, they should not be mixed with timing

// events that occurred in the foreground.

+// If |event_was_committed| is set then event can be a zero TimeDelta, otherwise

+// this function determines whether the event occurred by checking that event

+// is non-zero.

bool WasStartedInForegroundEventInForeground(base::TimeDelta event,

+ bool event_was_committed,

const PageLoadExtraInfo& info);

} // namespace page_load_metrics