Implement the password edit UI.

Implement the password edit UI.

See screenshot in bug.

BUG=595538
Committed: https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b
Cr-Commit-Position: refs/heads/master@{#383874}

[hcarmona, 2016-03-21 21:26:24]

Patchset #1 (id:1) has been deleted

[hcarmona, 2016-03-21 21:26:33]

Patchset #1 (id:20001) has been deleted

[hcarmona, 2016-03-21 21:30:55]

hcarmona@chromium.org changed reviewers:
+ dbeam@chromium.org

[hcarmona, 2016-03-21 21:30:56]

PTAL

This has the test that I fixed.
Screenshot in the bug.

[Dan Beam, 2016-03-25 03:02:55]

lgtm

https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
(right):

https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:13:
display: inline;
what is this doing? why are you using a block tag (<div>) just to make it
inline?

[hcarmona, 2016-03-25 18:21:07]

https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
(right):

https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:13:
display: inline;
On 2016/03/25 03:02:55, Dan Beam wrote:
> what is this doing? why are you using a block tag (<div>) just to make it
> inline?

Yes, is there a better way?

I want to have:

[input        ]
[input        ]
[input        ] [button]

but without the inline, the button drops down to the next row.

[hcarmona, 2016-03-29 00:07:20]

Updated based on our in-person chat.

I asked bettes@ about putting the icon into the input.
I'll create a new CL if changes are necessary.

https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
(right):

https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:13:
display: inline;
On 2016/03/25 18:21:07, Hector Carmona wrote:
> On 2016/03/25 03:02:55, Dan Beam wrote:
> > what is this doing? why are you using a block tag (<div>) just to make it
> > inline?
> 
> Yes, is there a better way?
> 
> I want to have:
> 
> [input        ]
> [input        ]
> [input        ] [button]
> 
> but without the inline, the button drops down to the next row.

Fixed based on our in-person chat.

[Dan Beam, 2016-03-29 00:07:29]

https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
(right):

https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:14:
}
remove this and figure out a way to apply display: flex; separately

[Dan Beam, 2016-03-29 00:12:01]

lgtm

https://codereview.chromium.org/1817123003/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
(right):

https://codereview.chromium.org/1817123003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp:11:
'<(DEPTH)/third_party/closure_compiler/externs/compiled_resources2.gyp:settings_private',
nit: maybe put externs at the bottom like other externs

[hcarmona, 2016-03-29 00:19:36]

https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
(right):

https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:14:
}
On 2016/03/29 00:07:29, Dan Beam wrote:
> remove this and figure out a way to apply display: flex; separately

I used an id and removed the class. How should I apply flex?

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
#hardware-acceleration does this the exact same way. Should I refactor
that to the settings_shared_css? Something like "--center-flex" and
@apply in both places?

[Dan Beam, 2016-03-29 01:33:20]

https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
(right):

https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:14:
}
On 2016/03/29 00:19:36, Hector Carmona wrote:
> On 2016/03/29 00:07:29, Dan Beam wrote:
> > remove this and figure out a way to apply display: flex; separately
> 
> I used an id and removed the class. How should I apply flex?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
> #hardware-acceleration does this the exact same way. Should I refactor
> that to the settings_shared_css? Something like "--center-flex" and
> @apply in both places?

there are aleady:

  @apply(--layout);
  @apply(--layout-center);

but all they do is add other (i.e. -ms-) styles and incur additional processing
time (either in the shim to do @apply() or in the browser in the future).

don't really feel like these are things that need to be shared, but up to you.

[hcarmona, 2016-03-29 02:00:34]

On 2016/03/29 01:33:20, Dan Beam wrote:
>
https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
> File
>
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
> (right):
> 
>
https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
>
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:14:
> }
> On 2016/03/29 00:19:36, Hector Carmona wrote:
> > On 2016/03/29 00:07:29, Dan Beam wrote:
> > > remove this and figure out a way to apply display: flex; separately
> > 
> > I used an id and removed the class. How should I apply flex?
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
> > #hardware-acceleration does this the exact same way. Should I refactor
> > that to the settings_shared_css? Something like "--center-flex" and
> > @apply in both places?
> 
> there are aleady:
> 
>   @apply(--layout);
>   @apply(--layout-center);
> 
> but all they do is add other (i.e. -ms-) styles and incur additional
processing
> time (either in the shim to do @apply() or in the browser in the future).
> 
> don't really feel like these are things that need to be shared, but up to you.

So... is this good? I'm a bit confused about what you're asking me to
change here.

I agree that it's not worth it to replace.

[Dan Beam, 2016-03-29 21:43:24]

On 2016/03/29 02:00:34, Hector Carmona wrote:
> On 2016/03/29 01:33:20, Dan Beam wrote:
> >
>
https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
> > File
> >
>
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
> > (right):
> > 
> >
>
https://codereview.chromium.org/1817123003/diff/40001/chrome/browser/resource...
> >
>
chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:14:
> > }
> > On 2016/03/29 00:19:36, Hector Carmona wrote:
> > > On 2016/03/29 00:07:29, Dan Beam wrote:
> > > > remove this and figure out a way to apply display: flex; separately
> > > 
> > > I used an id and removed the class. How should I apply flex?
> > > 
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
> > > #hardware-acceleration does this the exact same way. Should I refactor
> > > that to the settings_shared_css? Something like "--center-flex" and
> > > @apply in both places?
> > 
> > there are aleady:
> > 
> >   @apply(--layout);
> >   @apply(--layout-center);
> > 
> > but all they do is add other (i.e. -ms-) styles and incur additional
> processing
> > time (either in the shim to do @apply() or in the browser in the future).
> > 
> > don't really feel like these are things that need to be shared, but up to
you.
> 
> So... is this good? I'm a bit confused about what you're asking me to
> change here.
> 
> I agree that it's not worth it to replace.

good

[hcarmona, 2016-03-29 22:15:17]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2016-03-29 22:15:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1817123003/#ps80001
(title: "nit")

[commit-bot: I haz the power, 2016-03-29 22:15:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817123003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817123003/80001

[commit-bot: I haz the power, 2016-03-29 22:25:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 22:25:02]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hcarmona, 2016-03-29 22:42:35]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2016-03-29 22:42:35]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1817123003/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-29 22:43:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817123003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817123003/100001

[commit-bot: I haz the power, 2016-03-30 00:11:47]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-03-30 00:14:17]

Description was changed from

==========
Implement the password edit UI.

See screenshot in bug.

BUG=595538
==========

to

==========
Implement the password edit UI.

See screenshot in bug.

BUG=595538

Committed: https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b
Cr-Commit-Position: refs/heads/master@{#383874}
==========

[commit-bot: I haz the power, 2016-03-30 00:14:18]

Patchset 4 (id:??) landed as
https://crrev.com/2c67c3d74edbb8275a9fef22b236973e5f63332b
Cr-Commit-Position: refs/heads/master@{#383874}