Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4432)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

Issue 1817123003: Implement the password edit UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
index e38d132c0a6f433e82bc83fd928c9a80f4cdc8a1..bdb529b5464fa5318346766604c0adce36ec8f63 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
@@ -51,12 +51,27 @@ Polymer({
},
/**
+ * Shows the edit password dialog.
+ * @private
+ */
+ onMenuEditPasswordTap_: function() {
+ var menu = /** @type {CrSharedMenuElement} */(this.$.menu);
+ var data =
+ /** @type {chrome.passwordsPrivate.PasswordUiEntry} */(menu.itemData);
+ this.$.passwordEditDialog.item = data;
+ this.$.passwordEditDialog.open();
+ menu.closeMenu();
+ },
+
+ /**
* Fires an event that should delete the saved password.
* @private
*/
onMenuRemovePasswordTap_: function() {
var menu = /** @type {CrSharedMenuElement} */(this.$.menu);
- this.fire('remove-saved-password', menu.itemData);
+ var data =
+ /** @type {chrome.passwordsPrivate.PasswordUiEntry} */(menu.itemData);
+ this.fire('remove-saved-password', data.loginPair);
menu.closeMenu();
},
@@ -87,7 +102,7 @@ Polymer({
var target = /** @type {!Element} */(Polymer.dom(e).localTarget);
var passwordUiEntryEvent = /** @type {!PasswordUiEntryEvent} */(e);
- menu.toggleMenu(target, passwordUiEntryEvent.model.item.loginPair);
+ menu.toggleMenu(target, passwordUiEntryEvent.model.item);
e.stopPropagation(); // Prevent the tap event from closing the menu.
},

Powered by Google App Engine
This is Rietveld 408576698