Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Issue 1817123003: Implement the password edit UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
diff --git a/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js b/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
index 5cc6d8fc46d69087c0aa883bd347c1c94e2ac90e..6ba6a8999ee7b2e80f8de6601b04c3d436e2c7e8 100644
--- a/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
+++ b/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
@@ -112,10 +112,7 @@ SettingsPasswordSectionBrowserTest.prototype = {
passwordsSection.savedPasswords = passwordList;
passwordsSection.passwordExceptions = exceptionList;
document.body.appendChild(passwordsSection);
-
- // Allow polymer binding to finish.
- Polymer.dom.flush();
-
+ this.flush_(passwordsSection);
return passwordsSection;
},
@@ -131,6 +128,17 @@ SettingsPasswordSectionBrowserTest.prototype = {
}
return false;
},
+
+ /**
+ * Allow the iron-list to be sized properly.
+ * @param {!Object} passwordsSection
+ * @private
+ */
+ flush_: function(passwordsSection) {
+ passwordsSection.$.passwordList.notifyResize();
+ passwordsSection.$.passwordExceptionsList.notifyResize();
+ Polymer.dom.flush();
+ },
};
/**
@@ -178,7 +186,7 @@ TEST_F('SettingsPasswordSectionBrowserTest', 'uiTests', function() {
passwordList);
// Simulate 'longwebsite.com' being removed from the list.
passwordsSection.splice('savedPasswords', 1, 1);
- Polymer.dom.flush();
+ self.flush_(passwordsSection);
assertFalse(self.listContainsUrl(passwordsSection.savedPasswords,
'longwebsite.com'));
@@ -280,7 +288,7 @@ TEST_F('SettingsPasswordSectionBrowserTest', 'uiTests', function() {
passwordsSection.splice('passwordExceptions', 1, 1);
assertEquals(-1, passwordsSection.passwordExceptions.indexOf('mail.com'));
assertEquals(-1, exceptionList.indexOf('mail.com'));
- Polymer.dom.flush();
+ self.flush_(passwordsSection);
self.validateExceptionList_(
self.getIronListChildren_(passwordsSection.$.passwordExceptionsList),
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698