Improve Dart Debugger performance and robustness by creating Dart wrappers using the standard SetNa…

Source/bindings/v8/V8Binding.cpp

Index: Source/bindings/v8/V8Binding.cpp
diff --git a/Source/bindings/v8/V8Binding.cpp b/Source/bindings/v8/V8Binding.cpp
index 93f7167a1fcdd3619a403b4c7d001d730da3efa0..005ad353e6764424926e687b3ba4d10522be1b88 100644
--- a/Source/bindings/v8/V8Binding.cpp
+++ b/Source/bindings/v8/V8Binding.cpp
@@ -311,6 +311,10 @@ DOMWindow* toDOMWindow(v8::Handle<v8::Context> context)
     if (!window.IsEmpty())
         return V8DOMWindow::toNative(window);
     window = global->FindInstanceInPrototypeChain(V8DOMWindow::GetTemplate(context->GetIsolate(), IsolatedWorld));
+    if (window.IsEmpty()) {

[Anton Muhin, 2013/07/16 13:27:40]

when do you trigger this path?

[Jacob, 2013/07/16 16:44:59]

This path is triggered if you invoke a Dart method that logs to the console as
logging to the console in Dart triggers this path.

[Jacob, 2013/07/17 05:58:16]

It took far longer than it should but figured out a reasonable change to
DartDebugServer that removes the need for this hack.
Fixed the issue by running Dart snippets in the Debug context and making sure
that the evaluate method itself ran in the page context.

+        // FIXME: correct the Dart debugger implementation so this isn't required.
+        return toDOMWindow(v8::Context::GetEntered());
+    }
     ASSERT(!window.IsEmpty());
     return V8DOMWindow::toNative(window);
 }