Improve Dart Debugger performance and robustness by creating Dart wrappers using the standard SetNa…

Source/bindings/v8/V8Binding.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 293 matching lines @@
 }
 
 DOMWindow* toDOMWindow(v8::Handle<v8::Context> context)
 {
     v8::Handle<v8::Object> global = context->Global();
     ASSERT(!global.IsEmpty());
     v8::Handle<v8::Object> window = global->FindInstanceInPrototypeChain(V8DOMWindow::GetTemplate(context->GetIsolate(), MainWorld));
     if (!window.IsEmpty())
         return V8DOMWindow::toNative(window);
     window = global->FindInstanceInPrototypeChain(V8DOMWindow::GetTemplate(context->GetIsolate(), IsolatedWorld));
+    if (window.IsEmpty()) {

[Anton Muhin, 2013/07/16 13:27:40]

when do you trigger this path?

[Jacob, 2013/07/16 16:44:59]

This path is triggered if you invoke a Dart method that logs to the console as
logging to the console in Dart triggers this path.

[Jacob, 2013/07/17 05:58:16]

It took far longer than it should but figured out a reasonable change to
DartDebugServer that removes the need for this hack.
Fixed the issue by running Dart snippets in the Debug context and making sure
that the evaluate method itself ran in the page context.

+        // FIXME: correct the Dart debugger implementation so this isn't required.
+        return toDOMWindow(v8::Context::GetEntered());
+    }
     ASSERT(!window.IsEmpty());
     return V8DOMWindow::toNative(window);
 }
 
 ScriptExecutionContext* toScriptExecutionContext(v8::Handle<v8::Context> context)
 {
     v8::Handle<v8::Object> global = context->Global();
     v8::Handle<v8::Object> windowWrapper = global->FindInstanceInPrototypeChain(V8DOMWindow::GetTemplate(context->GetIsolate(), MainWorld));
     if (!windowWrapper.IsEmpty())
         return V8DOMWindow::toNative(windowWrapper)->scriptExecutionContext();
@@ skipping 103 matching lines @@
     if (!DOMWrapperWorld::isolatedWorldsExist())
         return MainWorld;
     ASSERT(!v8::Context::GetEntered().IsEmpty());
     DOMWrapperWorld* isolatedWorld = DOMWrapperWorld::isolatedWorld(v8::Context::GetEntered());
     if (isolatedWorld)
         return IsolatedWorld;
     return MainWorld;
 }
 
 } // namespace WebCore