Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: Source/bindings/dart/DartDOMWrapper.h

Issue 18169002: Improve Dart Debugger performance and robustness by creating Dart wrappers using the standard SetNa… (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: code review fixes Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/dart/DartDOMWrapper.h
diff --git a/Source/bindings/dart/DartDOMWrapper.h b/Source/bindings/dart/DartDOMWrapper.h
index a7c6cc080495f19a290c9d088f4ec70b7a0c28a0..5b2b058805e0f424aa0535b648169ff4f7f1cf2c 100644
--- a/Source/bindings/dart/DartDOMWrapper.h
+++ b/Source/bindings/dart/DartDOMWrapper.h
@@ -188,8 +188,8 @@ private:
{
intptr_t value;
Dart_Handle result = Dart_GetNativeInstanceField(wrapper, index, &value);
- ASSERT(!Dart_IsError(result));
- UNUSED_PARAM(result);
+ if (Dart_IsError(result))
Anton Muhin 2013/07/16 13:27:40 btw, that would lead to crashes as we don't want t
Jacob 2013/07/16 16:44:59 Would you like me to add a separate method maybeRe
+ return 0;
return reinterpret_cast<void*>(value);
}

Powered by Google App Engine
This is Rietveld 408576698