Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: test/cctest/interpreter/test-interpreter.cc

Issue 1816063002: [interpreter] Prepare for shipping --harmony-instanceof. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/test-interpreter.cc
diff --git a/test/cctest/interpreter/test-interpreter.cc b/test/cctest/interpreter/test-interpreter.cc
index f477b37443e3b5e8448209d57861acd1ae3f1a54..67191caabafe758598abd458bfef1ee08a8049b4 100644
--- a/test/cctest/interpreter/test-interpreter.cc
+++ b/test/cctest/interpreter/test-interpreter.cc
@@ -1450,6 +1450,11 @@ TEST(InterpreterStrictNotEqual) {
TEST(InterpreterInstanceOf) {
HandleAndZoneScope handles;
+ // TODO(4447): The new ES6 'instanceof' operator is fully desugared in the
+ // parser and the Token::INSTANCEOF is not needed anymore. This test only
+ // makes sense with --no-harmony-instanceof and can be removed once we
+ // deprecate the ability to switch to old skool ES5 'instanceof' for good.
+ FLAG_harmony_instanceof = false;
rmcilroy 2016/03/21 11:53:26 (fine to do this in a followup CL which removes th
Michael Starzinger 2016/03/21 12:00:08 Acknowledged. Yes, that would be another way to ad
i::Factory* factory = handles.main_isolate()->factory();
Handle<i::String> name = factory->NewStringFromAsciiChecked("cons");
Handle<i::JSFunction> func = factory->NewFunction(name);
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698