Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: chrome/browser/ui/login/login_prompt.cc

Issue 1815363002: Add RetainedRef uses where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/login/login_prompt.cc
diff --git a/chrome/browser/ui/login/login_prompt.cc b/chrome/browser/ui/login/login_prompt.cc
index abfc10dba5f9f2413d5cd4a5175768bdab07b752..32ea8d47aa9ffd8dd9687da904276d3e69e14965 100644
--- a/chrome/browser/ui/login/login_prompt.cc
+++ b/chrome/browser/ui/login/login_prompt.cc
@@ -565,10 +565,9 @@ void LoginDialogCallback(const GURL& request_url,
request_url.GetOrigin())) {
// Show a blank interstitial for main-frame, cross origin requests
// so that the correct URL is shown in the omnibox.
- base::Closure callback = base::Bind(&ShowLoginPrompt,
- request_url,
- make_scoped_refptr(auth_info),
- make_scoped_refptr(handler));
+ base::Closure callback =
+ base::Bind(&ShowLoginPrompt, request_url, base::RetainedRef(auth_info),
+ base::RetainedRef(handler));
// The interstitial delegate is owned by the interstitial that it creates.
// This cancels any existing interstitial.
handler->SetInterstitialDelegate(
@@ -589,7 +588,7 @@ LoginHandler* CreateLoginPrompt(net::AuthChallengeInfo* auth_info,
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::Bind(&LoginDialogCallback, request->url(),
- make_scoped_refptr(auth_info), make_scoped_refptr(handler),
+ base::RetainedRef(auth_info), base::RetainedRef(handler),
is_main_frame));
return handler;
}

Powered by Google App Engine
This is Rietveld 408576698