chrome/browser/themes/theme_service.cc - Issue 1815363002: Add RetainedRef uses where needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/theme_service.cc

Issue 1815363002: Add RetainedRef uses where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/themes/theme_service.cc

diff --git a/chrome/browser/themes/theme_service.cc b/chrome/browser/themes/theme_service.cc

index 208f11fd22b1aa85fe82b1913ddc74daca91a0a2..b5e070a298e25dac245c54424a2c2a0f203dd69a 100644

--- a/chrome/browser/themes/theme_service.cc

+++ b/chrome/browser/themes/theme_service.cc

@@ -769,7 +769,7 @@ void ThemeService::BuildFromExtension(const Extension* extension) {

: chrome::kThemePackFilename);

service->GetFileTaskRunner()->PostTask(

FROM_HERE,

- base::Bind(&WritePackToDiskCallback, pack, pack_path));

+ base::Bind(&WritePackToDiskCallback, base::RetainedRef(pack), pack_path));

// Save only the extension path. The packed file which matches the

// MaterialDesignController::Mode will be loaded via LoadThemePrefs().