Chromium Code Reviews| Index: content/browser/tracing/tracing_controller_impl.cc |
| diff --git a/content/browser/tracing/tracing_controller_impl.cc b/content/browser/tracing/tracing_controller_impl.cc |
| index c3d0e09193ecf2a7ff27f09a5a599640adb11d3b..c09b4e7458c703efd63356f299685cb67ec63c1e 100644 |
| --- a/content/browser/tracing/tracing_controller_impl.cc |
| +++ b/content/browser/tracing/tracing_controller_impl.cc |
| @@ -412,8 +412,8 @@ bool TracingControllerImpl::GetTraceBufferUsage( |
| BrowserThread::PostTask( |
| BrowserThread::UI, FROM_HERE, |
| base::Bind(&TracingControllerImpl::OnTraceLogStatusReply, |
| - base::Unretained(this), scoped_refptr<TraceMessageFilter>(), |
| - status)); |
| + base::Unretained(this), |
| + base::RetainedRef<TraceMessageFilter>(nullptr), status)); |
|
Nico
2016/03/18 21:01:01
ditto
|
| // Notify all child processes. |
| for (TraceMessageFilterSet::iterator it = trace_message_filters_.begin(); |
| @@ -470,10 +470,11 @@ bool TracingControllerImpl::IsTracing() const { |
| void TracingControllerImpl::AddTraceMessageFilter( |
| TraceMessageFilter* trace_message_filter) { |
| if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) { |
| - BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, |
| + BrowserThread::PostTask( |
| + BrowserThread::UI, FROM_HERE, |
| base::Bind(&TracingControllerImpl::AddTraceMessageFilter, |
| base::Unretained(this), |
| - make_scoped_refptr(trace_message_filter))); |
| + base::RetainedRef(trace_message_filter))); |
| return; |
| } |
| @@ -501,10 +502,11 @@ void TracingControllerImpl::AddTraceMessageFilter( |
| void TracingControllerImpl::RemoveTraceMessageFilter( |
| TraceMessageFilter* trace_message_filter) { |
| if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) { |
| - BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, |
| + BrowserThread::PostTask( |
| + BrowserThread::UI, FROM_HERE, |
| base::Bind(&TracingControllerImpl::RemoveTraceMessageFilter, |
| base::Unretained(this), |
| - make_scoped_refptr(trace_message_filter))); |
| + base::RetainedRef(trace_message_filter))); |
| return; |
| } |
| @@ -520,10 +522,11 @@ void TracingControllerImpl::RemoveTraceMessageFilter( |
| TraceMessageFilterSet::const_iterator it = |
| pending_stop_tracing_filters_.find(trace_message_filter); |
| if (it != pending_stop_tracing_filters_.end()) { |
| - BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, |
| + BrowserThread::PostTask( |
| + BrowserThread::UI, FROM_HERE, |
| base::Bind(&TracingControllerImpl::OnStopTracingAcked, |
| base::Unretained(this), |
| - make_scoped_refptr(trace_message_filter), |
| + base::RetainedRef(trace_message_filter), |
| std::vector<std::string>())); |
| } |
| } |
| @@ -535,7 +538,7 @@ void TracingControllerImpl::RemoveTraceMessageFilter( |
| BrowserThread::UI, FROM_HERE, |
| base::Bind(&TracingControllerImpl::OnTraceLogStatusReply, |
| base::Unretained(this), |
| - make_scoped_refptr(trace_message_filter), |
| + base::RetainedRef(trace_message_filter), |
| base::trace_event::TraceLogStatus())); |
| } |
| } |
| @@ -547,7 +550,7 @@ void TracingControllerImpl::RemoveTraceMessageFilter( |
| BrowserThread::UI, FROM_HERE, |
| base::Bind(&TracingControllerImpl::OnProcessMemoryDumpResponse, |
| base::Unretained(this), |
| - make_scoped_refptr(trace_message_filter), |
| + base::RetainedRef(trace_message_filter), |
| pending_memory_dump_guid_, false /* success */)); |
| } |
| } |
| @@ -605,11 +608,11 @@ void TracingControllerImpl::OnStopTracingAcked( |
| TraceMessageFilter* trace_message_filter, |
| const std::vector<std::string>& known_category_groups) { |
| if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) { |
| - BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, |
| - base::Bind(&TracingControllerImpl::OnStopTracingAcked, |
| - base::Unretained(this), |
| - make_scoped_refptr(trace_message_filter), |
| - known_category_groups)); |
| + BrowserThread::PostTask( |
| + BrowserThread::UI, FROM_HERE, |
| + base::Bind( |
| + &TracingControllerImpl::OnStopTracingAcked, base::Unretained(this), |
| + base::RetainedRef(trace_message_filter), known_category_groups)); |
| return; |
| } |
| @@ -720,7 +723,7 @@ void TracingControllerImpl::OnTraceLogStatusReply( |
| BrowserThread::UI, FROM_HERE, |
| base::Bind(&TracingControllerImpl::OnTraceLogStatusReply, |
| base::Unretained(this), |
| - make_scoped_refptr(trace_message_filter), status)); |
| + base::RetainedRef(trace_message_filter), status)); |
| return; |
| } |
| @@ -961,7 +964,7 @@ void TracingControllerImpl::OnProcessMemoryDumpResponse( |
| BrowserThread::UI, FROM_HERE, |
| base::Bind(&TracingControllerImpl::OnProcessMemoryDumpResponse, |
| base::Unretained(this), |
| - make_scoped_refptr(trace_message_filter), dump_guid, |
| + base::RetainedRef(trace_message_filter), dump_guid, |
| success)); |
| return; |
| } |