Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1815213002: Extends testb and cmpb/cmpw instruction support in the ia32 assembler. (Closed)

Created:
4 years, 9 months ago by epertoso
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Extends testb and cmpb/cmpw instruction support in the ia32 assembler. This is in preparation for a CL that does the equivalent of http://crrev.com/1780193003 for ia32. BUG= Committed: https://crrev.com/22523f25b1f788d331f7b4324889060136170ee1 Cr-Commit-Position: refs/heads/master@{#34925}

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Fix a copy/pasted erroneous DCHECK. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -94 lines) Patch
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 11 chunks +12 lines, -14 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 4 chunks +14 lines, -5 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 2 7 chunks +28 lines, -15 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 7 chunks +15 lines, -9 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 13 chunks +20 lines, -19 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 13 chunks +15 lines, -16 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ia32/ic-ia32.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M src/regexp/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-disasm-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
epertoso
verwaerst@ as an owner of src/ic jochen@ as an owner of src/regexp
4 years, 9 months ago (2016-03-18 15:43:52 UTC) #4
Toon Verwaest
src/ic lgtm
4 years, 9 months ago (2016-03-21 07:47:41 UTC) #5
Jarin
lgtm
4 years, 9 months ago (2016-03-21 07:55:58 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-21 07:58:57 UTC) #8
Benedikt Meurer
LGTM.
4 years, 9 months ago (2016-03-21 07:59:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815213002/20001
4 years, 9 months ago (2016-03-21 09:06:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/4656)
4 years, 9 months ago (2016-03-21 09:10:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815213002/20001
4 years, 9 months ago (2016-03-21 09:26:50 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/3218) v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-21 09:29:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815213002/40001
4 years, 9 months ago (2016-03-21 09:38:21 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-21 10:08:48 UTC) #22
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 10:09:31 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/22523f25b1f788d331f7b4324889060136170ee1
Cr-Commit-Position: refs/heads/master@{#34925}

Powered by Google App Engine
This is Rietveld 408576698