src/ia32/disasm-ia32.cc - Issue 1815213002: Extends testb and cmpb/cmpw instruction support in the ia32 assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/disasm-ia32.cc

Issue 1815213002: Extends testb and cmpb/cmpw instruction support in the ia32 assembler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix a copy/pasted erroneous DCHECK. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/disasm-ia32.cc

diff --git a/src/ia32/disasm-ia32.cc b/src/ia32/disasm-ia32.cc

index 69e7e7a450b93b0a4982abd830e65bf156640476..3cd0ac6e52fbe9d20e85faf60311971b80b18488 100644

--- a/src/ia32/disasm-ia32.cc

+++ b/src/ia32/disasm-ia32.cc

@@ -1621,6 +1621,13 @@ int DisassemblerIA32::InstructionDecode(v8::internal::Vector<char> out_buffer,

int imm = *reinterpret_cast<int16_t*>(data);

AppendToBuffer(",0x%x", imm);

data += 2;

+ } else if (*data == 0xF7) {

+ data++;

+ AppendToBuffer("%s ", "test_w");

+ data += PrintRightOperand(data);

+ int imm = *reinterpret_cast<int16_t*>(data);

+ AppendToBuffer(",0x%x", imm);

+ data += 2;

} else if (*data == 0x0F) {

data++;

if (*data == 0x38) {

« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »