Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 1814993002: Handle about:blank in the Origin Info Bubble better. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: No GetOpener at all. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_impl.h
diff --git a/content/browser/frame_host/navigation_entry_impl.h b/content/browser/frame_host/navigation_entry_impl.h
index 6614806ed86248252a72f68954eea952ad29cbc0..a4ce0af6285c7f2461606042f06fb291a7ccbe7e 100644
--- a/content/browser/frame_host/navigation_entry_impl.h
+++ b/content/browser/frame_host/navigation_entry_impl.h
@@ -21,6 +21,7 @@
#include "content/public/browser/navigation_entry.h"
#include "content/public/common/page_state.h"
#include "content/public/common/ssl_status.h"
+#include "url/origin.h"
namespace content {
struct CommonNavigationParams;
@@ -83,6 +84,8 @@ class CONTENT_EXPORT NavigationEntryImpl
PageType GetPageType() const override;
void SetURL(const GURL& url) override;
const GURL& GetURL() const override;
+ void SetOrigin(const url::Origin& origin) override;
+ const url::Origin& GetOrigin() const override;
void SetBaseURLForDataURL(const GURL& url) override;
const GURL& GetBaseURLForDataURL() const override;
#if defined(OS_ANDROID)
@@ -402,6 +405,14 @@ class CONTENT_EXPORT NavigationEntryImpl
base::Time timestamp_;
int http_status_code_;
+ // The effective Origin at the time of commit.
Charlie Reis 2016/04/19 22:32:52 Let's add that it starts as an empty, unique origi
+ //
+ // This member is not persisted with session restore because it is transient.
Charlie Reis 2016/04/19 22:32:52 nit: Drop "because it is transient." Also, no new
+ //
+ // TODO(creis): Move this to FrameNavigationEntry to make it useful for
+ // subframes as well.
+ url::Origin origin_;
+
// This member is not persisted with session restore because it is transient.
// If the post request succeeds, this field is cleared since the same
// information is stored in |content_state_| above. It is also only shallow

Powered by Google App Engine
This is Rietveld 408576698