Handle about:blank in the Origin Info Bubble better.

content/browser/frame_host/navigation_entry_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
 
 #include <stdint.h>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_vector.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "content/browser/frame_host/frame_navigation_entry.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/common/frame_message_enums.h"
 #include "content/public/browser/favicon_status.h"
 #include "content/public/browser/global_request_id.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/common/page_state.h"
 #include "content/public/common/ssl_status.h"
+#include "url/origin.h"
 
 namespace content {
 struct CommonNavigationParams;
 struct RequestNavigationParams;
 struct StartNavigationParams;
 
 class CONTENT_EXPORT NavigationEntryImpl
     : public NON_EXPORTED_BASE(NavigationEntry) {
  public:
   // Represents a tree of FrameNavigationEntries that make up this joint session
@@ skipping 42 matching lines @@
                       const base::string16& title,
                       ui::PageTransition transition_type,
                       bool is_renderer_initiated);
   ~NavigationEntryImpl() override;
 
   // NavigationEntry implementation:
   int GetUniqueID() const override;
   PageType GetPageType() const override;
   void SetURL(const GURL& url) override;
   const GURL& GetURL() const override;
+  void SetOrigin(const url::Origin& origin) override;
+  const url::Origin& GetOrigin() const override;
   void SetBaseURLForDataURL(const GURL& url) override;
   const GURL& GetBaseURLForDataURL() const override;
 #if defined(OS_ANDROID)
   void SetDataURLAsString(
       scoped_refptr<base::RefCountedString> data_url) override;
   const scoped_refptr<const base::RefCountedString> GetDataURLAsString()
       const override;
 #endif
   void SetReferrer(const Referrer& referrer) override;
   const Referrer& GetReferrer() const override;
@@ skipping 299 matching lines @@
   int32_t page_id_;
   SSLStatus ssl_;
   ui::PageTransition transition_type_;
   GURL user_typed_url_;
   RestoreType restore_type_;
   GURL original_request_url_;
   bool is_overriding_user_agent_;
   base::Time timestamp_;
   int http_status_code_;
 
+  // The effective Origin at the time of commit.

[Charlie Reis, 2016/04/19 22:32:52]

Let's add that it starts as an empty, unique origin (until the entry commits).

+  //
+  // This member is not persisted with session restore because it is transient.

[Charlie Reis, 2016/04/19 22:32:52]

nit: Drop "because it is transient."  Also, no new paragraph needed.

+  //
+  // TODO(creis): Move this to FrameNavigationEntry to make it useful for
+  // subframes as well.
+  url::Origin origin_;
+
   // This member is not persisted with session restore because it is transient.
   // If the post request succeeds, this field is cleared since the same
   // information is stored in |content_state_| above. It is also only shallow
   // copied with compiler provided copy constructor.
   // Cleared in |ResetForCommit|.
   scoped_refptr<const base::RefCountedMemory> browser_initiated_post_data_;
 
   // This is also a transient member (i.e. is not persisted with session
   // restore). The screenshot of a page is taken when navigating away from the
   // page. This screenshot is displayed during an overscroll-navigation
@@ skipping 87 matching lines @@
   // persisted, unless specific data is taken out/put back in at save/restore
   // time (see TabNavigation for an example of this).
   std::map<std::string, base::string16> extra_data_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_