Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 1814993002: Handle about:blank in the Origin Info Bubble better. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: No GetOpener at all. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index 9b3fd5e5e71d07b53a7e392405c6d1a49d36b913..d6b5715361413c48d9349c88bf1f6f5e572c545f 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -1113,6 +1113,7 @@ void NavigationControllerImpl::RendererDidNavigateToNewPage(
new_entry->set_page_type(params.url_is_unreachable ? PAGE_TYPE_ERROR
: PAGE_TYPE_NORMAL);
new_entry->SetURL(params.url);
+ new_entry->SetOrigin(url::Origin(params.url));
Charlie Reis 2016/04/19 22:32:52 Oh, I missed this before. This is wrong-- it'll b
if (update_virtual_url)
UpdateVirtualURLToURL(new_entry.get(), params.url);
new_entry->SetReferrer(params.referrer);
@@ -1180,6 +1181,7 @@ void NavigationControllerImpl::RendererDidNavigateToExistingPage(
entry->set_page_type(params.url_is_unreachable ? PAGE_TYPE_ERROR
: PAGE_TYPE_NORMAL);
entry->SetURL(params.url);
+ entry->SetOrigin(url::Origin(params.url));
entry->SetReferrer(params.referrer);
if (entry->update_virtual_url_with_url())
UpdateVirtualURLToURL(entry, params.url);
@@ -1241,6 +1243,7 @@ void NavigationControllerImpl::RendererDidNavigateToSamePage(
if (existing_entry->update_virtual_url_with_url())
UpdateVirtualURLToURL(existing_entry, params.url);
existing_entry->SetURL(params.url);
+ existing_entry->SetOrigin(url::Origin(params.url));
existing_entry->SetReferrer(params.referrer);
// The page may have been requested with a different HTTP method.

Powered by Google App Engine
This is Rietveld 408576698