third_party/WebKit/Source/web/WebPagePopupImpl.cpp - Issue 1814863002: Make page popups work under OOPIF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 1814863002: Make page popups work under OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disabled test on Mac Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

index 5d844b00e78e8e608f4eab4694998a3bee55dd31..74dce75d81f37924a8a8d4aa38c8674d1dddcc91 100644

--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

@@ -94,7 +94,7 @@ private:

return m_popup->m_windowRectInScreen;

}

- IntRect viewportToScreen(const IntRect& rect) const override

+ IntRect viewportToScreen(const IntRect& rect, const Widget* widget) const override

{

WebRect rectInScreen(rect);

m_popup->widgetClient()->convertViewportToWindow(&rectInScreen);

« no previous file with comments | « third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp ('k') | no next file » | no next file with comments »