Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 1814863002: Make page popups work under OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disabled test on Mac Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 void closeWindowSoon() override 87 void closeWindowSoon() override
88 { 88 {
89 m_popup->closePopup(); 89 m_popup->closePopup();
90 } 90 }
91 91
92 IntRect windowRect() override 92 IntRect windowRect() override
93 { 93 {
94 return m_popup->m_windowRectInScreen; 94 return m_popup->m_windowRectInScreen;
95 } 95 }
96 96
97 IntRect viewportToScreen(const IntRect& rect) const override 97 IntRect viewportToScreen(const IntRect& rect, const Widget* widget) const ov erride
98 { 98 {
99 WebRect rectInScreen(rect); 99 WebRect rectInScreen(rect);
100 m_popup->widgetClient()->convertViewportToWindow(&rectInScreen); 100 m_popup->widgetClient()->convertViewportToWindow(&rectInScreen);
101 rectInScreen.x += m_popup->m_windowRectInScreen.x; 101 rectInScreen.x += m_popup->m_windowRectInScreen.x;
102 rectInScreen.y += m_popup->m_windowRectInScreen.y; 102 rectInScreen.y += m_popup->m_windowRectInScreen.y;
103 return rectInScreen; 103 return rectInScreen;
104 } 104 }
105 105
106 void addMessageToConsole(LocalFrame*, MessageSource, MessageLevel, const Str ing& message, unsigned lineNumber, const String&, const String&) override 106 void addMessageToConsole(LocalFrame*, MessageSource, MessageLevel, const Str ing& message, unsigned lineNumber, const String&, const String&) override
107 { 107 {
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
561 // A WebPagePopupImpl instance usually has two references. 561 // A WebPagePopupImpl instance usually has two references.
562 // - One owned by the instance itself. It represents the visible widget. 562 // - One owned by the instance itself. It represents the visible widget.
563 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the 563 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
564 // WebPagePopupImpl to close. 564 // WebPagePopupImpl to close.
565 // We need them because the closing operation is asynchronous and the widget 565 // We need them because the closing operation is asynchronous and the widget
566 // can be closed while the WebViewImpl is unaware of it. 566 // can be closed while the WebViewImpl is unaware of it.
567 return adoptRef(new WebPagePopupImpl(client)).leakRef(); 567 return adoptRef(new WebPagePopupImpl(client)).leakRef();
568 } 568 }
569 569
570 } // namespace blink 570 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698