Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp

Issue 1814863002: Make page popups work under OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disabled test on Mac Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/PopupMenuImpl.cpp ('k') | third_party/WebKit/Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp b/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp
index 1774c10cbf60f19aac1a65e2c6bf2a5998c5a470..cc1399d2727919d1f70f56184df53e1677c277a6 100644
--- a/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp
@@ -73,7 +73,7 @@ void ValidationMessageClientImpl::showValidationMessage(const Element& anchor, c
hideValidationMessage(*m_currentAnchor);
m_currentAnchor = &anchor;
IntRect anchorInViewport = currentView()->contentsToViewport(anchor.pixelSnappedBoundingBox());
- m_lastAnchorRectInScreen = currentView()->getHostWindow()->viewportToScreen(anchorInViewport);
+ m_lastAnchorRectInScreen = currentView()->getHostWindow()->viewportToScreen(anchorInViewport, currentView());
m_lastPageScaleFactor = m_webView.pageScaleFactor();
m_message = message;
const double minimumSecondToShowValidationMessage = 5.0;
@@ -132,7 +132,7 @@ void ValidationMessageClientImpl::checkAnchorStatus(Timer<ValidationMessageClien
return;
}
- IntRect newAnchorRectInViewportInScreen = currentView()->getHostWindow()->viewportToScreen(newAnchorRectInViewport);
+ IntRect newAnchorRectInViewportInScreen = currentView()->getHostWindow()->viewportToScreen(newAnchorRectInViewport, currentView());
if (newAnchorRectInViewportInScreen == m_lastAnchorRectInScreen && m_webView.pageScaleFactor() == m_lastPageScaleFactor)
return;
m_lastAnchorRectInScreen = newAnchorRectInViewportInScreen;
« no previous file with comments | « third_party/WebKit/Source/web/PopupMenuImpl.cpp ('k') | third_party/WebKit/Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698