Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1562)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1814863002: Make page popups work under OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 17e4875da9c03244cd432c0eb68f07a05241f8d9..a4b6333396d6ddeae0819cef40e60d25dfa9b6d0 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2225,6 +2225,15 @@ void WebContentsImpl::SendScreenRects() {
RenderWidgetHostImpl::From(GetRenderViewHost()->GetWidget())
->SendScreenRects();
+ for (FrameTreeNode* node : frame_tree_.Nodes()) {
+ // TODO(kenrb): We skip the root, because it is already covered by the
+ // RenderViewHost call above. When RenderViewHost is no longer a
+ // RenderWidgetHost, this can be used to update all RenderWidgetHosts.
nasko 2016/03/17 17:25:45 RenderViewHost is no longer RenderWidgetHost, righ
kenrb 2016/03/17 18:59:48 Thanks for the tip, I didn't realize the top-level
+ if (node != frame_tree_.root() &&
+ node->current_frame_host()->GetRenderWidgetHost())
+ node->current_frame_host()->GetRenderWidgetHost()->SendScreenRects();
+ }
+
RenderWidgetHostViewBase* rwhv =
static_cast<RenderWidgetHostViewBase*>(GetRenderWidgetHostView());
if (rwhv) {

Powered by Google App Engine
This is Rietveld 408576698