Make page popups work under OOPIF

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <stddef.h>
 
 #include <cmath>
 #include <utility>
@@ skipping 2207 matching lines @@
 void WebContentsImpl::OnMoveValidationMessage(
     const gfx::Rect& anchor_in_root_view) {
   if (delegate_)
     delegate_->MoveValidationMessage(this, anchor_in_root_view);
 }
 
 void WebContentsImpl::SendScreenRects() {
   RenderWidgetHostImpl::From(GetRenderViewHost()->GetWidget())
       ->SendScreenRects();
 
+  for (FrameTreeNode* node : frame_tree_.Nodes()) {
+    // TODO(kenrb): We skip the root, because it is already covered by the
+    // RenderViewHost call above. When RenderViewHost is no longer a
+    // RenderWidgetHost, this can be used to update all RenderWidgetHosts.

[nasko, 2016/03/17 17:25:45]

RenderViewHost is no longer RenderWidgetHost, right? Why not remove the above
call and just iterate through all the nodes?
Also, even if they did inherit, why does that matter?

[kenrb, 2016/03/17 18:59:48]

Thanks for the tip, I didn't realize the top-level RenderFrameHost's widget
pointer points to the main RenderWidgetHost now. Fixed.

+    if (node != frame_tree_.root() &&
+        node->current_frame_host()->GetRenderWidgetHost())
+      node->current_frame_host()->GetRenderWidgetHost()->SendScreenRects();
+  }
+
   RenderWidgetHostViewBase* rwhv =
       static_cast<RenderWidgetHostViewBase*>(GetRenderWidgetHostView());
   if (rwhv) {
     SendPageMessage(new PageMsg_UpdateWindowScreenRect(
         MSG_ROUTING_NONE, rwhv->GetBoundsInRootWindow()));
   }
 
   if (browser_plugin_embedder_)
     browser_plugin_embedder_->DidSendScreenRects();
 }
@@ skipping 2616 matching lines @@
   else
     WasHidden();
 }
 
 void WebContentsImpl::SetJavaScriptDialogManagerForTesting(
     JavaScriptDialogManager* dialog_manager) {
   dialog_manager_ = dialog_manager;
 }
 
 }  // namespace content