Make page popups work under OOPIF

content/common/swapped_out_messages.cc

Index: content/common/swapped_out_messages.cc
diff --git a/content/common/swapped_out_messages.cc b/content/common/swapped_out_messages.cc
index a480310a7f82158fa81077fc849f5083fcdfda4b..05438c0d2759cf0efb32bf182a42545f8a7125b3 100644
--- a/content/common/swapped_out_messages.cc
+++ b/content/common/swapped_out_messages.cc
@@ -50,6 +50,7 @@ bool SwappedOutMessages::CanSendWhileSwappedOut(const IPC::Message* msg) {
     case FrameHostMsg_DidChangeOpener::ID:
     // Used in layout tests; handled in BlinkTestController.
     case ShellViewHostMsg_PrintMessage::ID:
+    case ViewHostMsg_CreateWidget::ID:

[nasko, 2016/03/17 17:25:45]

Generic question: why do we need to route this through RV(H) instead of RF(H) or
even RW(H)? It seems to me that we must know which frame is causing the popup
menu to appear, so it is a bit strange to see it routed through the RenderView.

[kenrb, 2016/03/17 18:59:48]

I had initially written a fairly large patch that moved all of this from
RenderView to RenderFrame, but then realized it didn't really solve the problem
and was a lot of unnecessary churn. Since the widget ends up getting owned by
the WebContents anyway, keeping this as page-level state seems to make sense.
The linkage between the popup and the owning element is maintained in the
renderer, so it just becomes extra complexity to try to associate it with a
local root.

[nasko, 2016/03/17 19:10:46]

Does it make sense to make it PageMsg in a follow up CL then? We can route it
through the top-level frame or proxy, which will get it delivered to WebContents
without the need to have swapped out exceptions.

[kenrb, 2016/03/17 20:00:06]

I have been assuming that every ViewMsg will get turned into a PageMsg, FrameMsg
or WidgetMsg at some point in the future. Is there a reason that kind of cleanup
would be a priority?

[nasko, 2016/03/17 21:05:31]

I didn't mean it should be a priority. It was a curiosity question. Yes, all
ViewMsg will disappear eventually. I was asking which of the three types of
message will it map to.

       return true;
     default:
       break;