Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: third_party/WebKit/Source/core/html/HTMLScriptElement.h

Issue 1814853003: Track whether an element was inserted via document.write (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLScriptElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLScriptElement.h b/third_party/WebKit/Source/core/html/HTMLScriptElement.h
index 75d1177bb566c37cee95697182ad2b2292bfdeda..cac1a93470322759447b20be4721aa36ccfb6f2b 100644
--- a/third_party/WebKit/Source/core/html/HTMLScriptElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLScriptElement.h
@@ -34,7 +34,7 @@ namespace blink {
class CORE_EXPORT HTMLScriptElement final : public HTMLElement, public ScriptLoaderClient {
DEFINE_WRAPPERTYPEINFO();
public:
- static PassRefPtrWillBeRawPtr<HTMLScriptElement> create(Document&, bool wasInsertedByParser, bool alreadyStarted = false);
+ static PassRefPtrWillBeRawPtr<HTMLScriptElement> create(Document&, bool wasInsertedByParser, bool alreadyStarted = false, bool createdDuringDocumentWrite = false);
kouhei (in TOK) 2016/03/18 02:24:26 Use two value enum here. (non-historic) Blink code
Charlie Harrison 2016/03/18 14:10:46 Are boolean members ok?
kouhei (in TOK) 2016/03/22 04:18:39 I don't see a rule for members, so I guess its ok.
String text() { return textFromChildren(); }
void setText(const String&);
@@ -49,7 +49,7 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
- HTMLScriptElement(Document&, bool wasInsertedByParser, bool alreadyStarted);
+ HTMLScriptElement(Document&, bool wasInsertedByParser, bool alreadyStarted, bool createdDuringDocumentWrite);
void parseAttribute(const QualifiedName&, const AtomicString&, const AtomicString&) override;
InsertionNotificationRequest insertedInto(ContainerNode*) override;

Powered by Google App Engine
This is Rietveld 408576698