third_party/WebKit/Source/core/html/HTMLScriptElement.cpp - Issue 1814853003: Track whether an element was inserted via document.write

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLScriptElement.cpp

Issue 1814853003: Track whether an element was inserted via document.write (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLScriptElement.h ('K') | « third_party/WebKit/Source/core/html/HTMLScriptElement.h ('k') | third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp » ('j') | third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLScriptElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp b/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp

index c04f3d4e5ba3d0689f589178e10982617abca9b9..16c8637077713fe2f4a674360a8d1a67d800f209 100644

--- a/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp

@@ -37,15 +37,15 @@ namespace blink {

using namespace HTMLNames;

-inline HTMLScriptElement::HTMLScriptElement(Document& document, bool wasInsertedByParser, bool alreadyStarted)

+inline HTMLScriptElement::HTMLScriptElement(Document& document, bool wasInsertedByParser, bool alreadyStarted, bool createdDuringDocumentWrite)

: HTMLElement(scriptTag, document)

- , m_loader(ScriptLoader::create(this, wasInsertedByParser, alreadyStarted))

+ , m_loader(ScriptLoader::create(this, wasInsertedByParser, alreadyStarted, createdDuringDocumentWrite))

{

}

-PassRefPtrWillBeRawPtr<HTMLScriptElement> HTMLScriptElement::create(Document& document, bool wasInsertedByParser, bool alreadyStarted)

+PassRefPtrWillBeRawPtr<HTMLScriptElement> HTMLScriptElement::create(Document& document, bool wasInsertedByParser, bool alreadyStarted, bool createdDuringDocumentWrite)

{

- return adoptRefWillBeNoop(new HTMLScriptElement(document, wasInsertedByParser, alreadyStarted));

+ return adoptRefWillBeNoop(new HTMLScriptElement(document, wasInsertedByParser, alreadyStarted, createdDuringDocumentWrite));

}

bool HTMLScriptElement::isURLAttribute(const Attribute& attribute) const

@@ -176,7 +176,7 @@ void HTMLScriptElement::dispatchLoadEvent()

PassRefPtrWillBeRawPtr<Element> HTMLScriptElement::cloneElementWithoutAttributesAndChildren()

{

- return adoptRefWillBeNoop(new HTMLScriptElement(document(), false, m_loader->alreadyStarted()));

+ return adoptRefWillBeNoop(new HTMLScriptElement(document(), false, m_loader->alreadyStarted(), false));

}

DEFINE_TRACE(HTMLScriptElement)