Track whether an element was inserted via document.write

third_party/WebKit/Source/core/html/HTMLScriptElement.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nikolas Zimmermann <zimmermann@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 16 matching lines @@
 #include "core/CoreExport.h"
 #include "core/dom/ScriptLoader.h"
 #include "core/dom/ScriptLoaderClient.h"
 #include "core/html/HTMLElement.h"
 
 namespace blink {
 
 class CORE_EXPORT HTMLScriptElement final : public HTMLElement, public ScriptLoaderClient {
     DEFINE_WRAPPERTYPEINFO();
 public:
-    static PassRefPtrWillBeRawPtr<HTMLScriptElement> create(Document&, bool wasInsertedByParser, bool alreadyStarted = false);
+    static PassRefPtrWillBeRawPtr<HTMLScriptElement> create(Document&, bool wasInsertedByParser, bool alreadyStarted = false, bool createdDuringDocumentWrite = false);

[kouhei (in TOK), 2016/03/18 02:24:26]

Use two value enum here.
(non-historic) Blink code is expected to use enum instead of bool. Example:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[Charlie Harrison, 2016/03/18 14:10:46]

Are boolean members ok?

[kouhei (in TOK), 2016/03/22 04:18:39]

I don't see a rule for members, so I guess its ok.

 
     String text() { return textFromChildren(); }
     void setText(const String&);
 
     KURL src() const;
 
     void setAsync(bool);
     bool async() const;
 
     ScriptLoader* loader() const { return m_loader.get(); }
 
     DECLARE_VIRTUAL_TRACE();
 
 private:
-    HTMLScriptElement(Document&, bool wasInsertedByParser, bool alreadyStarted);
+    HTMLScriptElement(Document&, bool wasInsertedByParser, bool alreadyStarted, bool createdDuringDocumentWrite);
 
     void parseAttribute(const QualifiedName&, const AtomicString&, const AtomicString&) override;
     InsertionNotificationRequest insertedInto(ContainerNode*) override;
     void didNotifySubtreeInsertionsToDocument() override;
     void childrenChanged(const ChildrenChange&) override;
     void didMoveToNewDocument(Document& oldDocument) override;
 
     bool isURLAttribute(const Attribute&) const override;
     bool hasLegalLinkAttribute(const QualifiedName&) const override;
     const QualifiedName& subResourceAttributeName() const override;
@@ skipping 11 matching lines @@
     void dispatchLoadEvent() override;
 
     PassRefPtrWillBeRawPtr<Element> cloneElementWithoutAttributesAndChildren() override;
 
     OwnPtrWillBeMember<ScriptLoader> m_loader;
 };
 
 } // namespace blink
 
 #endif // HTMLScriptElement_h