Store null GL context's state in interface object

Store null GL context's state in interface object

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1814113002

Committed: https://skia.googlesource.com/skia/+/b5a94e3e24ef16f96ecfbe4ee427f7a0c69d7290

[bsalomon, 2016-03-18 03:16:44]

Description was changed from

==========
start on converting test gl interfaces

BUG=skia:
==========

to

==========
start on converting test gl interfaces

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-03-18 14:46:34]

Description was changed from

==========
start on converting test gl interfaces

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Store null GL context's state in interface object

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-03-18 15:08:41]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2016-03-18 17:49:20]

lgtm

https://codereview.chromium.org/1814113002/diff/20001/src/gpu/gl/GrGLCreateNu...
File src/gpu/gl/GrGLCreateNullInterface.cpp (right):

https://codereview.chromium.org/1814113002/diff/20001/src/gpu/gl/GrGLCreateNu...
src/gpu/gl/GrGLCreateNullInterface.cpp:185: 
space this over ?

https://codereview.chromium.org/1814113002/diff/20001/src/gpu/gl/GrGLCreateNu...
src/gpu/gl/GrGLCreateNullInterface.cpp:302: GrGLvoid getProgramInfoLog(GrGLuint
program, GrGLsizei bufsize, GrGLsizei* length,
line up ?

[bsalomon, 2016-03-18 18:04:07]

https://codereview.chromium.org/1814113002/diff/20001/src/gpu/gl/GrGLCreateNu...
File src/gpu/gl/GrGLCreateNullInterface.cpp (right):

https://codereview.chromium.org/1814113002/diff/20001/src/gpu/gl/GrGLCreateNu...
src/gpu/gl/GrGLCreateNullInterface.cpp:185: 
On 2016/03/18 17:49:20, robertphillips wrote:
> space this over ?

Done.

https://codereview.chromium.org/1814113002/diff/20001/src/gpu/gl/GrGLCreateNu...
src/gpu/gl/GrGLCreateNullInterface.cpp:302: GrGLvoid getProgramInfoLog(GrGLuint
program, GrGLsizei bufsize, GrGLsizei* length,
On 2016/03/18 17:49:20, robertphillips wrote:
> line up ?

Done.

[bsalomon, 2016-03-18 18:04:11]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-03-18 18:04:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1814113002/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2016-03-18 18:04:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814113002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814113002/40001

[commit-bot: I haz the power, 2016-03-18 18:05:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 18:05:29]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[bsalomon, 2016-03-18 18:45:46]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-03-18 18:45:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1814113002/#ps60001
(title: "declare glEGLImageTargetTexture2DOES proc type locally in EGLGLContext"
")

[commit-bot: I haz the power, 2016-03-18 18:45:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814113002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814113002/60001

[commit-bot: I haz the power, 2016-03-18 18:47:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 18:47:42]

Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[bsalomon, 2016-03-18 18:56:37]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-03-18 18:56:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1814113002/#ps80001
(title: "add overrides")

[commit-bot: I haz the power, 2016-03-18 18:56:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814113002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814113002/80001

[commit-bot: I haz the power, 2016-03-18 19:07:26]

Description was changed from

==========
Store null GL context's state in interface object

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Store null GL context's state in interface object

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/b5a94e3e24ef16f96ecfbe4ee427f7a0c69d7290
==========

[commit-bot: I haz the power, 2016-03-18 19:07:27]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/b5a94e3e24ef16f96ecfbe4ee427f7a0c69d7290