Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Issue 1813533002: Replace -[IOBluetoothL2CAPChannel getDevice] with -[IOBluetoothL2CAPChannel device]. (Closed)

Created:
4 years, 9 months ago by erikchen
Modified:
4 years, 9 months ago
Reviewers:
scheib
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp20_107_keychain
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace -[IOBluetoothL2CAPChannel getDevice] with -[IOBluetoothL2CAPChannel device]. The former method is deprecated, the latter is not. They have the same functionality. https://developer.apple.com/library/mac/releasenotes/General/MacOSXLionAPIDiffs/IOBluetooth.html BUG=592663 Committed: https://crrev.com/8468b4eb877dd991361f0da7541c7da961c8b3c7 Cr-Commit-Position: refs/heads/master@{#381618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M device/bluetooth/bluetooth_l2cap_channel_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
erikchen
scheib: Please review.
4 years, 9 months ago (2016-03-16 22:49:35 UTC) #2
scheib
LGTM, I added the URL to the change that documents the API deprecation.
4 years, 9 months ago (2016-03-16 23:31:35 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1813523002 Patch 1). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-16 23:33:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813533002/1
4 years, 9 months ago (2016-03-16 23:58:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 01:05:09 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 01:06:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8468b4eb877dd991361f0da7541c7da961c8b3c7
Cr-Commit-Position: refs/heads/master@{#381618}

Powered by Google App Engine
This is Rietveld 408576698