Suppress -Wdeprecated-declarations warnings in apple_keychain_mac.mm.

Suppress -Wdeprecated-declarations warnings in apple_keychain_mac.mm.

This is required to update the deployment target to OS X 10.7. Eventually, the
deprecated Keychain methods should be removed entirely.

BUG=595468, 592663
Committed: https://crrev.com/c519490e5d3dff205429762976cfb07065e0a307
Cr-Commit-Position: refs/heads/master@{#381593}

[erikchen, 2016-03-16 22:43:26]

erikchen@chromium.org changed reviewers:
+ davidben@google.com

[erikchen, 2016-03-16 22:43:27]

davidben: Please review.

[erikchen, 2016-03-16 22:43:56]

erikchen@chromium.org changed reviewers:
+ davidben@chromium.org
- davidben@google.com

[erikchen, 2016-03-16 22:43:56]

cc-ing the right account.

[davidben, 2016-03-16 22:52:02]

davidben@chromium.org changed reviewers:
+ rsleevi@chromium.org

[davidben, 2016-03-16 22:52:02]

Tossing this to Ryan since I don't know the story behind those APIs and whether
this is another of those that Apple doesn't have a replacement for.

[Ryan Sleevi, 2016-03-16 23:07:45]

Here we do actually have alternatives, and
https://bugs.chromium.org/p/chromium/issues/detail?id=595468 could totally fixed
by using SecKeychainFindInternetPassword

Concrete steps to resolve this:
1) Add a FindInternetPassword method to apple_keychain.h that calls
SecKeychainFindInternetPassword in the .mm
2) Update password_store_mac to use that, rather than the
SearchCreateFromAttributes/SearchCopyNext method it is presently using
3) Remove these two methods

You could also go the SecItemCopyMatching, but it may be simpler to reduce our
surface.

So, for suppressions, this LGTM, and I strongly agree with 595468 needing to be
resolved, which could remove all this code.

[erikchen, 2016-03-16 23:11:42]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-03-16 23:12:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1813523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1813523002/1

[commit-bot: I haz the power, 2016-03-16 23:55:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-16 23:58:02]

Description was changed from

==========
Suppress -Wdeprecated-declarations warnings in apple_keychain_mac.mm.

This is required to update the deployment target to OS X 10.7. Eventually, the
deprecated Keychain methods should be removed entirely.

BUG=595468, 592663
==========

to

==========
Suppress -Wdeprecated-declarations warnings in apple_keychain_mac.mm.

This is required to update the deployment target to OS X 10.7. Eventually, the
deprecated Keychain methods should be removed entirely.

BUG=595468, 592663

Committed: https://crrev.com/c519490e5d3dff205429762976cfb07065e0a307
Cr-Commit-Position: refs/heads/master@{#381593}
==========

[commit-bot: I haz the power, 2016-03-16 23:58:02]

Patchset 1 (id:??) landed as
https://crrev.com/c519490e5d3dff205429762976cfb07065e0a307
Cr-Commit-Position: refs/heads/master@{#381593}