Update BookmarkBarController to use non-deprecated dragging APIs.

Update BookmarkBarController to use non-deprecated dragging APIs.

This CL theoretically should not produce any behavior change.

This CL replaces the method -[NSView dragImage:...] with -[NSView
beginDraggingSessionWithItems:...]. There are three major differences.

1. The new API is asynchronous, whereas the old one ran a nested run loop. This
CL runs a nested run loop to maintain the previous behavior.
2. The new API makes use of some new terminology and protocols
(NSDraggingSession, NSDraggingSource, etc.) but the underlying logic is still
the same. This CL renames some methods and variables.
3. The new API requires that custom PasteBoard types use reverse DNS notation.

BUG=592663
Committed: https://crrev.com/f2200abc5d620cc7495635767bf833aacd7af48f
Cr-Commit-Position: refs/heads/master@{#382722}

[erikchen, 2016-03-18 00:43:48]

Description was changed from

==========
Update BookmarkBarController to use non-deprecated dragging APIs.

BUG=
==========

to

==========
Update BookmarkBarController to use non-deprecated dragging APIs.

This CL theoretically should not produce any behavior change.

This CL replaces the method -[NSView dragImage:...] with -[NSView
beginDraggingSessionWithItems:...]. There are three major differences.

1. The new API is asynchronous, whereas the old one ran a nested run loop. This
CL runs a nested run loop to maintain the previous behavior.
2. The new API makes use of some new terminology and protocols
(NSDraggingSession, NSDraggingSource, etc.) but the underlying logic is still
the same. This CL renames some methods and variables.
3. The new API requires that custom PasteBoard types use reverse DNS notation.

BUG=592663
==========

[erikchen, 2016-03-18 00:46:11]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 00:46:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815053002/20001

[commit-bot: I haz the power, 2016-03-18 00:51:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 00:51:24]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[erikchen, 2016-03-18 00:56:27]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 00:56:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815053002/40001

[commit-bot: I haz the power, 2016-03-18 01:00:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 01:00:38]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[erikchen, 2016-03-18 16:54:34]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 16:54:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815053002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815053002/60001

[commit-bot: I haz the power, 2016-03-18 18:14:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 18:14:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-03-18 18:43:18]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 18:44:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815053002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815053002/80001

[commit-bot: I haz the power, 2016-03-18 19:02:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 19:02:39]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-03-18 20:13:29]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 20:14:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815053002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815053002/100001

[commit-bot: I haz the power, 2016-03-18 21:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 21:27:47]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-03-18 21:33:27]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org

[erikchen, 2016-03-18 21:33:28]

avi: Please review.

[Avi (use Gerrit), 2016-03-18 21:41:03]

Reasonable. Some questions.

https://codereview.chromium.org/1815053002/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/bookmarks/bookmark_button.h (left):

https://codereview.chromium.org/1815053002/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/bookmarks/bookmark_button.h:193: @interface
BookmarkButton : DraggableButton<ThemedWindowDrawing> {
Are we not implementing that interface any more? I thought this was a change of
the dragging code only.

https://codereview.chromium.org/1815053002/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm (right):

https://codereview.chromium.org/1815053002/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm:220: forTypes:[NSArray
arrayWithObjects:kBookmarkButtonDragType, nil]];
@[ kBookmarkButtonDragType ]

?

[erikchen, 2016-03-18 22:20:35]

avi: PTAL

https://codereview.chromium.org/1815053002/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/bookmarks/bookmark_button.h (left):

https://codereview.chromium.org/1815053002/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/bookmarks/bookmark_button.h:193: @interface
BookmarkButton : DraggableButton<ThemedWindowDrawing> {
On 2016/03/18 21:41:03, Avi wrote:
> Are we not implementing that interface any more? I thought this was a change
of
> the dragging code only.

oops! Accidentally removed this line in a recent change set.

https://codereview.chromium.org/1815053002/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm (right):

https://codereview.chromium.org/1815053002/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm:220: forTypes:[NSArray
arrayWithObjects:kBookmarkButtonDragType, nil]];
On 2016/03/18 21:41:03, Avi wrote:
> @[ kBookmarkButtonDragType ]
> 
> ?

Done.

[Avi (use Gerrit), 2016-03-18 22:28:15]

lgtm

[erikchen, 2016-03-18 23:08:23]

erikchen@chromium.org changed reviewers:
+ mark@chromium.org

[erikchen, 2016-03-18 23:08:24]

mark: Please review base/

[Mark Mentovai, 2016-03-22 22:01:13]

LGTM

[erikchen, 2016-03-22 22:03:41]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-03-22 22:04:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815053002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815053002/120001

[commit-bot: I haz the power, 2016-03-22 23:03:11]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-22 23:05:38]

Description was changed from

==========
Update BookmarkBarController to use non-deprecated dragging APIs.

This CL theoretically should not produce any behavior change.

This CL replaces the method -[NSView dragImage:...] with -[NSView
beginDraggingSessionWithItems:...]. There are three major differences.

1. The new API is asynchronous, whereas the old one ran a nested run loop. This
CL runs a nested run loop to maintain the previous behavior.
2. The new API makes use of some new terminology and protocols
(NSDraggingSession, NSDraggingSource, etc.) but the underlying logic is still
the same. This CL renames some methods and variables.
3. The new API requires that custom PasteBoard types use reverse DNS notation.

BUG=592663
==========

to

==========
Update BookmarkBarController to use non-deprecated dragging APIs.

This CL theoretically should not produce any behavior change.

This CL replaces the method -[NSView dragImage:...] with -[NSView
beginDraggingSessionWithItems:...]. There are three major differences.

1. The new API is asynchronous, whereas the old one ran a nested run loop. This
CL runs a nested run loop to maintain the previous behavior.
2. The new API makes use of some new terminology and protocols
(NSDraggingSession, NSDraggingSource, etc.) but the underlying logic is still
the same. This CL renames some methods and variables.
3. The new API requires that custom PasteBoard types use reverse DNS notation.

BUG=592663

Committed: https://crrev.com/f2200abc5d620cc7495635767bf833aacd7af48f
Cr-Commit-Position: refs/heads/master@{#382722}
==========

[commit-bot: I haz the power, 2016-03-22 23:05:39]

Patchset 7 (id:??) landed as
https://crrev.com/f2200abc5d620cc7495635767bf833aacd7af48f
Cr-Commit-Position: refs/heads/master@{#382722}

[erikchen, 2016-04-01 14:55:19]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1853503004/ by erikchen@chromium.org.

The reason for reverting is: Prevents drag and drop from bookmark bar to
tabstrip:
https://bugs.chromium.org/p/chromium/issues/detail?id=599522.