Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1813123003: Reland of "switch patheffects over to sk_sp (patchset #5 id:80001 of https://codereview.chromium.or… (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of "switch patheffects over to sk_sp (patchset #5 id:80001 of https://codereview.chromium.org/1813553005/ )" This reverts commit f28ad894272018fd2855e3f77ea1236ea0cce1c0. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1813123003 TBR= Committed: https://skia.googlesource.com/skia/+/a439334b6e758d38501e225e2e5d0ab73e2fb6eb

Patch Set 1 #

Patch Set 2 : move flag into sktypes, so it is visible to both paint and other patheffect clients #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -255 lines) Patch
M bench/DashBench.cpp View 11 chunks +11 lines, -14 lines 0 comments Download
M gm/arcto.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bug530095.cpp View 3 chunks +6 lines, -7 lines 0 comments Download
M gm/dashcircle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/dashcubics.cpp View 1 chunk +16 lines, -18 lines 0 comments Download
M gm/dashing.cpp View 6 chunks +6 lines, -7 lines 0 comments Download
M gm/pathcontourstart.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M gm/patheffects.cpp View 4 chunks +11 lines, -13 lines 0 comments Download
M gm/strokes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/stroketext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/textbloblooper.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/texteffects.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkPaint.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M include/core/SkPathEffect.h View 1 5 chunks +26 lines, -15 lines 0 comments Download
M include/core/SkTypes.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M include/effects/Sk1DPathEffect.h View 1 chunk +7 lines, -1 line 0 comments Download
M include/effects/Sk2DPathEffect.h View 2 chunks +4 lines, -4 lines 0 comments Download
M include/effects/SkArcToPathEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkCornerPathEffect.h View 1 chunk +9 lines, -1 line 0 comments Download
M include/effects/SkDashPathEffect.h View 1 chunk +7 lines, -1 line 0 comments Download
M include/effects/SkDiscretePathEffect.h View 1 chunk +5 lines, -1 line 0 comments Download
M samplecode/ClockFaceView.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M samplecode/SampleAll.cpp View 7 chunks +9 lines, -12 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 2 chunks +15 lines, -19 lines 0 comments Download
M samplecode/SamplePath.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SamplePathEffects.cpp View 3 chunks +16 lines, -21 lines 0 comments Download
M samplecode/SampleSlides.cpp View 9 chunks +17 lines, -19 lines 0 comments Download
M src/animator/SkDrawPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPaint.cpp View 1 3 chunks +5 lines, -3 lines 0 comments Download
M src/core/SkPathEffect.cpp View 4 chunks +13 lines, -33 lines 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/effects/Sk1DPathEffect.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/effects/Sk2DPathEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkArcToPathEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkCornerPathEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDashPathEffect.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkDiscretePathEffect.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M src/effects/SkLayerDrawLooper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrTextUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/xps/SkXPSDevice.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/AsADashTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/DashPathEffectTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/DrawPathTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/GpuDrawPathTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/PictureTest.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813123003/20001
4 years, 9 months ago (2016-03-18 17:44:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813123003/20001
4 years, 9 months ago (2016-03-18 18:08:37 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 18:23:00 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a439334b6e758d38501e225e2e5d0ab73e2fb6eb

Powered by Google App Engine
This is Rietveld 408576698